- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
add BestEffortDebug<T>, an always-Debug wrapper over T irrespective of T: Debug / T: !Debug #49071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      198c1ab
              
                add core/alloc/std::fmt::WrapDebug
              
              
                Centril 3c314fa
              
                add core/alloc/std::fmt::WrapDebug - #![feature(core_intrinsics)] in …
              
              
                Centril 05287c8
              
                add core/alloc/std::fmt::WrapDebug - global path core::intrinsics::ty…
              
              
                Centril d61e0b6
              
                add core/alloc/std::fmt::WrapDebug - fix use intrinsics::type_name
              
              
                Centril b472dc2
              
                add core/alloc/std::fmt::WrapDebug - rewrite logic using `trait WrapD…
              
              
                Centril f36dc46
              
                add core/alloc/std::fmt::WrapDebug - fix use intrinsics::type_name
              
              
                Centril beeabd0
              
                Merge branch 'master' into feature/wrap-debug
              
              
                Centril 88a196b
              
                rename WrapDebug to BestEffortDebug
              
              
                Centril File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
is !Debugpart of the message is jargon-y and hard to understand. My idea of an improvement would be"[<unknown value> of type {}]"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on the hard to understand bit, how about this?
The point of this being that if a library user sees this, they will know that they should bug the library author with a request to add
#[derive(Debug)].There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(That's much better, and I think the reason for that is good)