Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only generate miri backtraces if explicitly requested #49083

Merged
merged 1 commit into from
Mar 17, 2018
Merged

Only generate miri backtraces if explicitly requested #49083

merged 1 commit into from
Mar 17, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 16, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2018
@michaelwoerister
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2018

📌 Commit 4133b16 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2018
@alexcrichton
Copy link
Member

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Mar 17, 2018
@kennytm
Rollup merge of rust-lang#49083 - oli-obk:mopsgeschwindigkeit, r=mich…
ef9581e 
…aelwoerister

Only generate miri backtraces if explicitly requested

fixes rust-lang#49072
fixes rust-lang#48888

r? @michaelwoerister
@kennytm kennytm mentioned this pull request Mar 17, 2018
Merged
bors added a commit that referenced this pull request Mar 17, 2018
@bors
Auto merge of #49106 - kennytm:rollup, r=kennytm
61b6bf5 
Rollup of 8 pull requests

- Successful merges: #48943, #48960, #48983, #49055, #49057, #49077, #49082, #49083
- Failed merges:
@bors bors merged commit 4133b16 into rust-lang:master Mar 17, 2018
pravic
pravic reviewed Mar 17, 2018
View reviewed changes
src/librustc/mir/interpret/error.rs
@@ -20,7 +20,7 @@ pub struct EvalError<'tcx> {

impl<'tcx> From<EvalErrorKind<'tcx>> for EvalError<'tcx> {
fn from(kind: EvalErrorKind<'tcx>) -> Self {
let backtrace = match env::var("RUST_BACKTRACE") {
let backtrace = match env::var("MIRI_BACKTRACE") {
Ok(ref val) if !val.is_empty() => Some(Backtrace::new_unresolved()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it looks like backtrace will be generated even with RUST_BACKTRACE=0. Is this okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is not your regular backtrace, this is inside miri for debugging miri error sources

@oli-obk oli-obk deleted the mopsgeschwindigkeit branch March 17, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravic pravic pravic left review comments

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly compilation is infinite (2018-03-15) Crash building libstd on FreeBSD after miri const eval changes.
6 participants
@oli-obk @michaelwoerister @bors @alexcrichton @pravic @rust-highfive