Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable testing librustdoc #49090

Merged
merged 2 commits into from
Mar 17, 2018
Merged

re-enable testing librustdoc #49090

merged 2 commits into from
Mar 17, 2018

Conversation

QuietMisdreavus
Copy link
Member

This was originally put in in #44274, but #48105 accidentally hid it. This change puts librustdoc unit/doc tests back in the main test listing.

fixes #44237 (again)

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2018
@QuietMisdreavus QuietMisdreavus changed the title re-enable resting librustdoc re-enable testing librustdoc Mar 16, 2018
@QuietMisdreavus QuietMisdreavus mentioned this pull request Mar 16, 2018
Closed
@QuietMisdreavus
Copy link
Member Author

I have no idea if rustdoc's tests have regressed in the month this has been out, so we'll see what Travis says... >_>

@Mark-Simulacrum
Copy link
Member

@bors r+ p=10 (we should be running tests)

@bors
Copy link
Contributor

bors commented Mar 16, 2018

📌 Commit 6a38e61 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2018
@bors
Copy link
Contributor

bors commented Mar 16, 2018

⌛ Testing commit 6a38e61 with merge 3a267c1531f9cfac6918a9626346e1cc68b22aeb...

@bors
Copy link
Contributor

bors commented Mar 17, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2018
@QuietMisdreavus
Copy link
Member Author

@bors retry

Timeout on android (#38851 ?)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2018
@bors
Copy link
Contributor

bors commented Mar 17, 2018

⌛ Testing commit 6a38e61 with merge 8cabda4...

bors added a commit that referenced this pull request Mar 17, 2018
@bors
Auto merge of #49090 - QuietMisdreavus:test-rustdoc-again, r=Mark-Sim…
8cabda4 
…ulacrum

re-enable testing librustdoc

This was originally put in in #44274, but #48105 accidentally hid it. This change puts librustdoc unit/doc tests back in the main test listing.

fixes #44237 (again)
@bors
Copy link
Contributor

bors commented Mar 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 8cabda4 to master...

@bors bors merged commit 6a38e61 into rust-lang:master Mar 17, 2018
@bors bors mentioned this pull request Mar 17, 2018
Merged
@QuietMisdreavus QuietMisdreavus deleted the test-rustdoc-again branch April 17, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustdoc unit tests not being run by Rustbuild
5 participants
@QuietMisdreavus @rust-highfive @Mark-Simulacrum @bors @nikomatsakis