rustbuild: Ship libsynchronization #49125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ship libsynchronization from MinGW
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 1e73c1d has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 19, 2018
rustbuild: Ship libsynchronization Hot on the heels of rust-lang#49044 comes similar issue with libsynchronization. Discovered while building clippy: ``` <skipped> Compiling serde_derive v1.0.33 error: linking with `gcc` failed: exit code: 1 <skipped> = note: ld: cannot find -lsynchronization ``` r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of #49044 comes similar issue with libsynchronization. Discovered while building clippy:
r? @nikomatsakis