Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify AcqRel's docs #49170

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Clarify AcqRel's docs #49170

merged 2 commits into from
Mar 26, 2018

Conversation

steveklabnik
Copy link
Member

This implied things that are not true.

Fixes #49127

This implied things that are not true.

Fixes rust-lang#49127
@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2018
@pietroalbini
Copy link
Member

Highfive failed to assign an reviewer, picking someone randomly from the docs team.

r? @frewsxcv

@bors
Copy link
Contributor

bors commented Mar 19, 2018

@pietroalbini: 🔑 Insufficient privileges: Not in reviewers

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit deae8de has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@nagisa
Copy link
Member

nagisa commented Mar 20, 2018

Well, lets see. The new wording seems as ambiguous to me. One can interpret the new wording as being equivalent to SeqCst in most cases (since Acquire and Release are the two disjoint parts of SeqCst, usually).

Can we just note that this ordering is only applicable for operations that combine both loads and stores and for loads it then uses acquire ordering and for stores it would use the release ordering?

@steveklabnik
Copy link
Member Author

@bors: r-

@nagisa sure, I'll try to hammer that into something. I mostly think that the current wording is very misleading; I'm not particularly attached to my wording here.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018
@steveklabnik
Copy link
Member Author

r? @nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned frewsxcv Mar 25, 2018
@nagisa
Copy link
Member

nagisa commented Mar 25, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 25, 2018

📌 Commit 23013c7 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 25, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 26, 2018
Clarify AcqRel's docs

This implied things that are not true.

Fixes rust-lang#49127
TimNN added a commit to TimNN/rust that referenced this pull request Mar 26, 2018
Clarify AcqRel's docs

This implied things that are not true.

Fixes rust-lang#49127
bors added a commit that referenced this pull request Mar 26, 2018
Rollup of 7 pull requests

- Successful merges: #48693, #48932, #49103, #49170, #49187, #49346, #49353
- Failed merges:
@bors bors merged commit 23013c7 into rust-lang:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants