Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest ! for erroneous identifier not #49258

Merged
merged 2 commits into from
Apr 10, 2018
Merged

suggest ! for erroneous identifier not #49258

merged 2 commits into from
Apr 10, 2018

Commits on Apr 9, 2018

  1. don't suggest placing code in block if next token is open-brace 

    Thanks to the inestimably inimitable Esteban "Estebank" Küber for
pointing this out.

This is relevant to rust-lang#46836.
    @zackmdavis
    zackmdavis committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    944c401 View commit details
    Browse the repository at this point in the history

  2. in which ! is suggested for erroneous identifier not 

    Impressing confused Python users with magical diagnostics is perhaps
worth this not-grossly-unreasonable (only 40ish lines) extra complexity
in the parser?

Thanks to Vadim Petrochenkov for guidance.

This resolves rust-lang#46836.
    @zackmdavis
    zackmdavis committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    ba0dd8e View commit details
    Browse the repository at this point in the history