Produce nice array lengths on a best effort basis #49262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
commented
Mar 22, 2018
| @@ -46,7 +46,7 @@ error[E0223]: ambiguous associated type | |||
| LL | type A = [u8; 4]::AssocTy; | |||
| | ^^^^^^^^^^^^^^^^ ambiguous associated type | |||
| | | |||
| = note: specify the type using the syntax `<[u8; <unevaluated[]>] as Trait>::AssocTy` | |||
There was a problem hiding this comment.
I did not fix this case because it would have been very involved. The error reporting mechanisms around this error are very string heavy. This would need to be addressed in a future PR
|
@bors r+ rollup |
|
📌 Commit b48a26c has been approved by |
bors
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 23, 2018
…ebank Produce nice array lengths on a best effort basis fixes rust-lang#49208 r? @estebank
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 23, 2018
…ebank Produce nice array lengths on a best effort basis fixes rust-lang#49208 r? @estebank
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2018
…ebank Produce nice array lengths on a best effort basis fixes rust-lang#49208 r? @estebank
bors
added a commit
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49208
r? @estebank