Skip to content

Fix stable hashing of AllocIds #49424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Fix stable hashing of AllocIds #49424

merged 1 commit into from
Mar 30, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 27, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@oli-obk oli-obk force-pushed the stable_allocid_hash branch from 475c41d to fa60b72 Compare March 28, 2018 08:12
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 28, 2018

ok, travis actually passes now

@michaelwoerister
Copy link
Member

Thanks, @oli-obk!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 28, 2018

📌 Commit fa60b72 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
@bors
Copy link
Collaborator

bors commented Mar 30, 2018

⌛ Testing commit fa60b72 with merge 051050d...

bors added a commit that referenced this pull request Mar 30, 2018
@bors
Auto merge of #49424 - oli-obk:stable_allocid_hash, r=michaelwoerister
051050d 
Fix stable hashing of AllocIds

r? @michaelwoerister

fixes #49081
@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 30, 2018
@bors
Copy link
Collaborator

bors commented Mar 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 051050d to master...

@bors bors merged commit fa60b72 into rust-lang:master Mar 30, 2018
@oli-obk oli-obk removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 30, 2018
@oli-obk oli-obk deleted the stable_allocid_hash branch March 30, 2018 23:12
@oli-obk oli-obk mentioned this pull request Mar 30, 2018
Closed
@ehuss ehuss mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIRI: Tried to cache DefId(_), but was already existing as AllocId(_)
4 participants
@oli-obk @michaelwoerister @bors @rust-highfive