Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle impl trait in external items in rustdoc #49427

Merged
merged 5 commits into from
Mar 29, 2018
Merged

Correctly handle impl trait in external items in rustdoc #49427

merged 5 commits into from
Mar 29, 2018

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Mar 27, 2018 •
edited
Loading

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2018
@Manishearth
Copy link
Member Author

(test coming soon)

@Manishearth Manishearth added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2018
@Manishearth
Copy link
Member Author

cc @alexcrichton we may want this for the beta

@Manishearth Manishearth mentioned this pull request Mar 27, 2018
Closed
@alexcrichton
Copy link
Member

Ah sorry but it's too late at this point to make it into 1.25 unless this is really urgent

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2018
@Manishearth
Copy link
Member Author

Oh, I'm talking about the 1.26 beta -- the beta that's being created soon. We can backport this later as well, I figure that if we can merge this in now (provided it gets reviewed before) that would be easier.

@GuillaumeGomez
Copy link
Member

Tests are failing btw.

@Manishearth
Copy link
Member Author

Yeah, it's tidy, forgot to fix it

@Manishearth
Copy link
Member Author

Fixed

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 28, 2018

📌 Commit 33dceaa has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49427 - Manishearth:rustdoc-impl-trait-exte…
6ca1466 
…rn, r=GuillaumeGomez

Correctly handle impl trait in external items in rustdoc

fixes rust-lang#49373

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Mar 28, 2018
Merged
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49460 - kennytm:rollup, r=kennytm
d52c44e 
Rollup of 12 pull requests

- Successful merges: #49243, #49329, #49364, #49400, #49405, #49427, #49428, #49429, #49439, #49442, #49444, #49452
- Failed merges:
@bors bors merged commit 33dceaa into rust-lang:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustdoc doesn't render all impl Trait details
6 participants
@Manishearth @rust-highfive @alexcrichton @GuillaumeGomez @bors @QuietMisdreavus