Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #49744

Closed
wants to merge 16 commits into from
Closed

Rollup of 8 pull requests #49744

wants to merge 16 commits into from

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Apr 6, 2018

Successful merges:

Failed merges:

GuillaumeGomez and others added 16 commits March 30, 2018 15:16
This commit applies a few code size optimizations for the wasm target to
the standard library, namely around panics. We notably know that in most
configurations it's impossible for us to print anything in
wasm32-unknown-unknown so we can skip larger portions of panicking that
are otherwise simply informative. This allows us to get quite a nice
size reduction.

Finally we can also tweak where the allocation happens for the
`Box<Any>` that we panic with. By only allocating once unwinding starts
we can reduce the size of a panicking wasm module from 44k to 350 bytes.
These were showing up in tests and in binaries but are trivially optimize-able
away, so add `#[inline]` attributes so LLVM has an opportunity to optimize them
out.
This includes search for all books, a long-requested feature!
This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678.
…ackler

std: Minimize size of panicking on wasm

This commit applies a few code size optimizations for the wasm target to
the standard library, namely around panics. We notably know that in most
configurations it's impossible for us to print anything in
wasm32-unknown-unknown so we can skip larger portions of panicking that
are otherwise simply informative. This allows us to get quite a nice
size reduction.

Finally we can also tweak where the allocation happens for the
`Box<Any>` that we panic with. By only allocating once unwinding starts
we can reduce the size of a panicking wasm module from 44k to 350 bytes.
…n, r=QuietMisdreavus

Fix anchor position on fields

Take a look at `Option` variants for example and try to click on `§` to get the issue.

r? @QuietMisdreavus
…aumeGomez

update mdbook

This includes search for all books, a long-requested feature!
…QuietMisdreavus

Fix anchors issue when everything is collapsed

Fixes rust-lang#49455.

@frewsxcv does it seem good for you like this?

r? @QuietMisdreavus
…-Simulacrum

std: Inline some Termination-related methods

These were showing up in tests and in binaries but are trivially optimize-able
away, so add `#[inline]` attributes so LLVM has an opportunity to optimize them
out.
…Mark-Simulacrum

bootstrap: Remove the help fast path

This is rarely noticed, but when you have old submodules, not updating them will cause you run into rust-lang/cargo#4678.
…richton

add THUMB targets to rustup manifest

as instructed in rust-lang#49563 (comment)

r? @alexcrichton
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2018
@kennytm
Copy link
Member Author

kennytm commented Apr 6, 2018

@bors r+ p=8

@bors
Copy link
Contributor

bors commented Apr 6, 2018

📌 Commit 4b459aa has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2018
@bors
Copy link
Contributor

bors commented Apr 6, 2018

⌛ Testing commit 4b459aa with merge 0cd192455f210bee0b8c9f09b5296dad06888099...

@bors
Copy link
Contributor

bors commented Apr 6, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 6, 2018
@TimNN
Copy link
Contributor

TimNN commented Apr 6, 2018

Your PR failed on Travis. Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:31:25] died due to signal 11
[01:31:25] error: test failed, to rerun pass '--test coretests'
[01:31:25]
[01:31:25]
[01:31:25] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--"
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:305cebc8:start=1523051333028400675,finish=1523051333058232563,duration=29831888
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:03ca3308
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:03ca3308:start=1523051333064462498,finish=1523051333086751318,duration=22288820
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0098e425
$ dmesg | grep -i kill
[   10.707881] init: failsafe main process (1097) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN.

@kennytm kennytm closed this Apr 6, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.