[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped #49808

spastorino · 2018-04-09T17:10:13Z

nikomatsakis · 2018-04-09T19:04:49Z

src/librustc_mir/borrow_check/nll/explain_borrow/mod.rs

+                                    }
+
+                                    err.span_label(
+                                        mir.source_info(p).span,


actually maybe we can just do mir.local_decls[local].source_info.span here and not bother to search for locals?

ht @nickfrostatx for the first initial patch

nikomatsakis · 2018-04-10T00:06:05Z

@bors r+

bors · 2018-04-10T00:06:06Z

📌 Commit 2c79f64 has been approved by nikomatsakis

bors · 2018-04-10T11:45:11Z

⌛ Testing commit 2c79f64 with merge 63331dca5476098f01aeb9f9ea65ccb6a26ae65c...

bors · 2018-04-10T11:50:14Z

💔 Test failed - status-travis

TimNN · 2018-04-10T11:50:16Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:01] tar: Skipping to next header
[00:00:02] src/ci/init_repo.sh: line 46:  3745 Segmentation fault      (core dumped) tar -C $module --strip-components=1 -xf $cached
---
[00:00:24] error during connect: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.32/images/load?quiet=1: EOF
[00:00:24] Downloaded containers:\n
[00:00:24] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-powerpc64-linux/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:24] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused"
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="Can't add file /home/travis/build/rust-lang/rust/src/ci/docker/armhf-gnu/vexpress_config to tar: io: read/write on closed pipe"
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="Can't close tar writer: io: read/write on closed pipe"
[00:00:24] Command failed. Attempt 2/5:
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="failed to dial gRPC: unable to upgrade to h2c, received 501"
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="Can't add file /home/travis/build/rust-lang/rust/src/ci/docker/dist-armhf-linux/arm-linux-gnueabihf.config to tar: io: read/write on closed pipe"
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="Can't close tar writer: io: read/write on closed pipe"
[00:00:25] context canceled
---
[00:01:05] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:01:05] time="2018-04-10T11:48:10Z" level=error msg="failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused"
[00:01:05] Command failed. Attempt 5/5:
[00:01:05] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:01:05] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:23008758:start=1523360890406521546,finish=1523360890414622333,duration=8100787
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:069eaaaf
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:069eaaaf:start=1523360890420113670,finish=1523360890425995570,duration=5881900
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13913500
$ dmesg | grep -i kill
[   10.573652] init: failsafe main process (1095) killed by TERM signal
[   33.307545] init: docker main process (1158) killed by ILL signal
[  133.074003] init: docker main process (4350) killed by SEGV signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

TimNN · 2018-04-10T11:50:19Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:01] tar: Skipping to next header
[00:00:02] src/ci/init_repo.sh: line 46:  3745 Segmentation fault      (core dumped) tar -C $module --strip-components=1 -xf $cached
---
[00:00:24] error during connect: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.32/images/load?quiet=1: EOF
[00:00:24] Downloaded containers:\n
[00:00:24] Attempting with retry: docker build --rm -t rust-ci -f /home/travis/build/rust-lang/rust/src/ci/docker/dist-powerpc64-linux/Dockerfile /home/travis/build/rust-lang/rust/src/ci/docker
[00:00:24] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused"
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="Can't add file /home/travis/build/rust-lang/rust/src/ci/docker/armhf-gnu/vexpress_config to tar: io: read/write on closed pipe"
[00:00:24] time="2018-04-10T11:47:28Z" level=error msg="Can't close tar writer: io: read/write on closed pipe"
[00:00:24] Command failed. Attempt 2/5:
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="failed to dial gRPC: unable to upgrade to h2c, received 501"
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="Can't add file /home/travis/build/rust-lang/rust/src/ci/docker/dist-armhf-linux/arm-linux-gnueabihf.config to tar: io: read/write on closed pipe"
[00:00:25] time="2018-04-10T11:47:29Z" level=error msg="Can't close tar writer: io: read/write on closed pipe"
[00:00:25] context canceled
---
[00:01:05] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:01:05] time="2018-04-10T11:48:10Z" level=error msg="failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused"
[00:01:05] Command failed. Attempt 5/5:
[00:01:05] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[00:01:05] The command has failed after 5 attempts.
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:23008758:start=1523360890406521546,finish=1523360890414622333,duration=8100787
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:069eaaaf
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:069eaaaf:start=1523360890420113670,finish=1523360890425995570,duration=5881900
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13913500
$ dmesg | grep -i kill
[   10.573652] init: failsafe main process (1095) killed by TERM signal
[   33.307545] init: docker main process (1158) killed by ILL signal
[  133.074003] init: docker main process (4350) killed by SEGV signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nikomatsakis · 2018-04-10T14:21:14Z

@bors retry

"Cannot connect to the Docker daemon"..looks spurious to me

kennytm · 2018-04-13T15:10:06Z

@bors p=3

bors · 2018-04-13T16:06:21Z

⌛ Testing commit 2c79f64 with merge 9c2bfcb...

@nikomatsakis

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped Fixes #47646 r? @nikomatsakis

bors · 2018-04-13T18:55:43Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 9c2bfcb to master...

rust-highfive assigned nikomatsakis Apr 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2018

spastorino force-pushed the dump_cause_ice branch from 5a97467 to 5934079 Compare April 9, 2018 17:12

rust-lang deleted a comment from rust-highfive Apr 9, 2018

rust-lang deleted a comment from TimNN Apr 9, 2018

spastorino force-pushed the dump_cause_ice branch 2 times, most recently from 95f143d to 9b704ae Compare April 9, 2018 17:47

rust-lang deleted a comment from TimNN Apr 9, 2018

spastorino force-pushed the dump_cause_ice branch from 9b704ae to 54d1569 Compare April 9, 2018 18:59

nikomatsakis reviewed Apr 9, 2018

View reviewed changes

spastorino force-pushed the dump_cause_ice branch from 54d1569 to 937886e Compare April 9, 2018 19:34

spastorino changed the title ~~[WIP] [NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped~~ [NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped Apr 9, 2018

spastorino added 2 commits April 9, 2018 17:35

Fix ICE when a borrow is used after drop

2e87dbb

ht @nickfrostatx for the first initial patch

rustfmt explain_borrow/mod

2c79f64

spastorino force-pushed the dump_cause_ice branch from 937886e to 2c79f64 Compare April 9, 2018 20:36

rust-lang deleted a comment from TimNN Apr 9, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 10, 2018

This was referenced Apr 10, 2018

ICE： NLL bug? #49616

Closed

unexpected panic Option::unwrap() on a None value' with NLL #49097

Closed

nikomatsakis mentioned this pull request Apr 10, 2018

Temporary lifetimes sometimes yield surprising errors #46413

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018

bors added a commit that referenced this pull request Apr 13, 2018

Auto merge of #49808 - spastorino:dump_cause_ice, r=nikomatsakis

9c2bfcb

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped Fixes #47646 r? @nikomatsakis

bors merged commit 2c79f64 into rust-lang:master Apr 13, 2018

bors mentioned this pull request Apr 13, 2018

prep work for using timely dataflow with NLL #49836

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped #49808

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped #49808

spastorino commented Apr 9, 2018 •

edited

Loading

nikomatsakis Apr 9, 2018

nikomatsakis commented Apr 10, 2018

bors commented Apr 10, 2018

bors commented Apr 10, 2018

bors commented Apr 10, 2018

TimNN commented Apr 10, 2018

TimNN commented Apr 10, 2018

nikomatsakis commented Apr 10, 2018

kennytm commented Apr 13, 2018

bors commented Apr 13, 2018

bors commented Apr 13, 2018

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped #49808

[NLL] Fix ICE when a borrow wrapped in a temporary is used after dropped #49808

Conversation

spastorino commented Apr 9, 2018 • edited Loading

nikomatsakis Apr 9, 2018

Choose a reason for hiding this comment

nikomatsakis commented Apr 10, 2018

bors commented Apr 10, 2018

bors commented Apr 10, 2018

bors commented Apr 10, 2018

TimNN commented Apr 10, 2018

TimNN commented Apr 10, 2018

nikomatsakis commented Apr 10, 2018

kennytm commented Apr 13, 2018

bors commented Apr 13, 2018

bors commented Apr 13, 2018

spastorino commented Apr 9, 2018 •

edited

Loading