Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Be sure to modify atomics in tests #49811

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

alexcrichton
Copy link
Member

See #49775 for some more information but it looks like this is working around an
LLVM bug for the time being.

Closes #49775

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2018
@SimonSapin
Copy link
Contributor

SimonSapin commented Apr 9, 2018

Should have a code comment linking to #49775 (comment)

@bors: p=20

(Some unrelated approved PR fail to land because of the bug this fixes.)

See rust-lang#49775 for some more information but it looks like this is working around an
LLVM bug for the time being.

Closes rust-lang#49775
@SimonSapin
Copy link
Contributor

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 9, 2018

📌 Commit 69c3830 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2018
@bors
Copy link
Contributor

bors commented Apr 9, 2018

⌛ Testing commit 69c3830 with merge 880fbd7...

bors added a commit that referenced this pull request Apr 9, 2018
std: Be sure to modify atomics in tests

See #49775 for some more information but it looks like this is working around an
LLVM bug for the time being.

Closes #49775
@bors
Copy link
Contributor

bors commented Apr 10, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: SimonSapin
Pushing 880fbd7 to master...

@bors bors merged commit 69c3830 into rust-lang:master Apr 10, 2018
@alexcrichton alexcrichton deleted the fix-android branch April 20, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants