Partial work making libsyntax free of vecs_implicitly_copyable #4999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming the changes here are mechanical, hence am rubber-stamping so it can get into the build queue :-) |
|
I've rebased my patch onto HEAD so it's merge-able again. |
|
@erickt I'm so sorry, but it's already not merge-able -- would you mind rebasing one more time? I'll try to approve it right away if you do :-) |
bors
added a commit
that referenced
this pull request
Feb 19, 2013
This patch series is doing a couple things with the ultimate goal of removing `#[allow(vecs_implicitly_copyable)]`, although I'm not quite there yet. The main change is passing around `@~str`s in most places, and using `ref`s in others. As far as I could tell, there are no performance changes with these patches, and all the tests pass on my mac.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…rdering, r=phansch
Add lint to detect usage of invalid atomic ordering
Detect usage of invalid atomic ordering modes such as `Ordering::{Release, AcqRel}` in atomic loads and `Ordering::{Acquire, AcqRel}` in atomic stores.
Fixes rust-lang#4679
changelog: Add lint [`invalid_atomic_ordering`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series is doing a couple things with the ultimate goal of removing
#[allow(vecs_implicitly_copyable)], although I'm not quite there yet. The main change is passing around@~strs in most places, and usingrefs in others. As far as I could tell, there are no performance changes with these patches, and all the tests pass on my mac.