Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder injection of std to get better compilation error #50006

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

rcoh
Copy link
Contributor

@rcoh rcoh commented Apr 16, 2018

Per #49851, reorder injection imports to get a better error message.

r? @oli-obk

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Apr 17, 2018

@bors r+

Thanks.

I didn't know about the error syntax with line info. That's really funky

@bors
Copy link
Contributor

bors commented Apr 17, 2018

📌 Commit 084d2bc has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2018
@bors
Copy link
Contributor

bors commented Apr 18, 2018

⌛ Testing commit 084d2bc with merge c8fa49f...

bors added a commit that referenced this pull request Apr 18, 2018
Reorder injection of std to get better compilation error

Per #49851, reorder injection imports to get a better error message.

r? @oli-obk
@bors
Copy link
Contributor

bors commented Apr 18, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing c8fa49f to master...

@bors bors merged commit 084d2bc into rust-lang:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants