Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize a bunch of minor api additions #50017

Merged
merged 7 commits into from
Apr 18, 2018

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Apr 17, 2018

besides ptr::NonNull::cast (which is 4 days away from end of FCP) all of these have been finished with FCP for a few weeks now with minimal issues raised

the following functions will be stabilized in 1.27:

  • [T]::rsplit
  • [T]::rsplit_mut
  • [T]::swap_with_slice
  • ptr::swap_nonoverlapping
  • NonNull::cast
  • Duration::from_micros
  • Duration::from_nanos
  • Duration::subsec_millis
  • Duration::subsec_micros
  • HashMap::remove_entry

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2018
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:00:50] configure: rust.quiet-tests     := True
---
[00:03:06] error[E0541]: unknown meta item 'issue'
[00:03:06]    --> libcore/time.rs:168:43
[00:03:06]     |
[00:03:06] 168 |     #[stable(feature = "duration_extras", issue = "1.27.0")]
---
[00:03:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:03:27] expected success, got: exit code: 101
[00:03:27] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1085:9
[00:03:27] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:03:27] travis_fold:end:stage0-std
[00:03:27] travis_time:end:stage0-std:start=1523942275425743987,finish=1523942301523247101,duration=26097503114
[00:03:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:27] Build completed unsuccessfully in 0:00:27
[00:03:27] Makefile:79: recipe for target 'tidy' failed
[00:03:27] make: *** [tidy] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:081e1704:start=1523942302010125166,finish=1523942302017219719,duration=7094553
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:04acdaa4
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:04acdaa4:start=1523942302023102973,finish=1523942302030158280,duration=7055307
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:174a5ce7
$ dmesg | grep -i kill
[   10.558849] init: failsafe main process (1094) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Apr 17, 2018
@sfackler
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 18, 2018

📌 Commit fd042ee has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2018
@bors
Copy link
Contributor

bors commented Apr 18, 2018

⌛ Testing commit fd042ee with merge ac3c228...

bors added a commit that referenced this pull request Apr 18, 2018
stabilize a bunch of minor api additions

besides `ptr::NonNull::cast` (which is 4 days away from end of FCP) all of these have been finished with FCP for a few weeks now with minimal issues raised

* Closes #41020
* Closes #42818
* Closes #44030
* Closes #44400
* Closes #46507
* Closes #47653
* Closes #46344

the following functions will be stabilized in 1.27:
* `[T]::rsplit`
* `[T]::rsplit_mut`
* `[T]::swap_with_slice`
* `ptr::swap_nonoverlapping`
* `NonNull::cast`
* `Duration::from_micros`
* `Duration::from_nanos`
* `Duration::subsec_millis`
* `Duration::subsec_micros`
* `HashMap::remove_entry`
@bors
Copy link
Contributor

bors commented Apr 18, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing ac3c228 to master...

@bors bors merged commit fd042ee into rust-lang:master Apr 18, 2018
@tinaun tinaun deleted the stabilize-all-the-things branch April 19, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants