Add -C target-feature to all functions
#50188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 23, 2018
|
r? @eddyb |
|
@bors r+ |
|
📌 Commit 27f99d9 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 27f99d9edc90eebd7b215e53a073ed92c8bc8031 with merge de50959da437473d1e530cf2e7ab4a394ff3b89a... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Previously the features specified to LLVM via `-C target-feature` were only reflected in the `TargetMachine` but this change *also* reflects these and the base features inside each function itself. This change matches clang and... Closes rust-lang/stdarch#427
alexcrichton
force-pushed
the
feature-all-the-things
branch
from
27f99d9 to
6223711
Compare
|
@bors: r=eddyb |
|
📌 Commit 6223711 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 28, 2018
Add `-C target-feature` to all functions Previously the features specified to LLVM via `-C target-feature` were only reflected in the `TargetMachine` but this change *also* reflects these and the base features inside each function itself. This change matches clang and... Closes rust-lang/stdarch#427
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the features specified to LLVM via
-C target-featurewere onlyreflected in the
TargetMachinebut this change also reflects these and thebase features inside each function itself. This change matches clang and...
Closes rust-lang/stdarch#427