os::make_absolute() and WindowsPath Refactoring and Fixes #5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deleted my r+, not sure if that will make bors not build it (or if it already saw the r+). |
|
The old logic for joining did not account for windows. I felt like moving that into make_absolute would mean that people would have to reimplement the logic if they want to make it absolute to a different bade path than the processes working directory. |
bors
added a commit
that referenced
this pull request
Feb 26, 2013
…rphism This pull request moves the logic from os::make_absolute() into the path module and fixes path joining for Windows. It does this by adding an ``unsafe_join()`` function that implements the operating system's path joining semantics. Additionally it also adds an ``is_restricted()`` method to the trait which will return true if the path points to a windows device file.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
Omit doc safety/errors header checking for main This omits checking `main` methods, which are not usually documented in the way the others are. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the logic from os::make_absolute() into the path module and fixes path joining for Windows. It does this by adding an
unsafe_join()function that implements the operating system's path joining semantics.Additionally it also adds an
is_restricted()method to the trait which will return true if the path points to a windows device file.