Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Remove dependency on parking_lot #50254

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Commits on Apr 26, 2018

  1. [beta] Remove dependency on parking_lot

    Unfortunately the `parking_lot` crate enables the `synchapi` feature of the
    `winapi` crate which activates a dependency on `libsynchronization.a`. The MinGW
    version of `libsynchronization.a` pulls in a dependency
    `api-ms-core-synch-l1-2-0.dll` which causes rustc to not work on Windows 7
    (tracked in rust-lang#49438)
    
    The `parking_lot` crate is not currently used in the compiler unless parallel
    queries are enabled. This feature is not enabled by default and not used at all
    in the beta/stable compilers. As a result the dependency in this commit was
    removed and the CI build which checks parallel queries was disabled.
    
    This isn't a great long-term solution but should hopefully be enough of a patch
    for beta to buy us some more time to figure this out.
    alexcrichton committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    93fb6b6 View commit details
    Browse the repository at this point in the history