Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't feature gate bang macros on 'proc_macro_path_invoc'. #50295

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

SergioBenitez
Copy link
Contributor

@SergioBenitez SergioBenitez commented Apr 28, 2018

Fixes oversight from #50120.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2018
@SergioBenitez
Copy link
Contributor Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Awesome, thanks @SergioBenitez!

@bors
Copy link
Collaborator

bors commented Apr 28, 2018

📌 Commit f756b07 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2018
@petrochenkov
Copy link
Contributor

This is a breaking regression, so maybe let's land it faster.
@bors p=1

@bors
Copy link
Collaborator

bors commented Apr 28, 2018

⌛ Testing commit f756b07 with merge 7c1fd19fceaab184f1e5d32e82ffb6674f2df74c...

@bors
Copy link
Collaborator

bors commented Apr 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2018
@rust-highfive
Copy link
Contributor

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:31:53] [RUSTC-TIMING] rustc_target test:false 25.050
[00:31:54] [RUSTC-TIMING] syntax_pos test:false 10.427
[00:31:54]    Compiling rustc_errors v0.0.0 (file:///checkout/src/librustc_errors)
[00:32:05] [RUSTC-TIMING] rustc_errors test:false 10.930
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:31:53] [RUSTC-TIMING] rustc_target test:false 25.050
[00:31:54] [RUSTC-TIMING] syntax_pos test:false 10.427
[00:31:54]    Compiling rustc_errors v0.0.0 (file:///checkout/src/librustc_errors)
[00:32:05] [RUSTC-TIMING] rustc_errors test:false 10.930
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2018
@bors
Copy link
Collaborator

bors commented Apr 28, 2018

⌛ Testing commit f756b07 with merge 1e01e22...

bors added a commit that referenced this pull request Apr 28, 2018
Don't feature gate bang macros on 'proc_macro_path_invoc'.

Fixes oversight from #50120.
@bors
Copy link
Collaborator

bors commented Apr 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1e01e22 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants