Remove vestigial diverging !-coercion #50351
Conversation
Such conversions are no longer permitted.
This comment has been minimized.
This comment has been minimized.
This was explicitly testing the behaviour which is now no longer permitted.
| @@ -690,7 +690,7 @@ https://doc.rust-lang.org/reference/types.html#trait-objects"); | |||
| arm_span: arm.body.span, | |||
| source: match_src | |||
| }); | |||
| coercion.coerce(self, &cause, &arm.body, arm_ty, self.diverges.get()); | |||
| coercion.coerce(self, &cause, &arm.body, arm_ty); | |||
There was a problem hiding this comment.
👍 -- the fact that this parameter was still needed should have been a warning sign. sigh.
| // Accepted: return is coerced to `!` just fine, and then `22` can be | ||
| // because we already diverged. | ||
| let x: [!; 2] = [return, 22]; | ||
| // Accepted: return is coerced to `!` just fine, but `22` cannot be. |
There was a problem hiding this comment.
Nit: This is no longer "accepted"
|
@bors try |
Remove vestigial diverging !-coercion Such conversions are no longer permitted. Fixes #50350. r? @nikomatsakis
|
cc @rust-lang/infra -- this could use a "check-only" crater run. |
nikomatsakis
added
the
S-waiting-on-crater
|
☀️ Test successful - status-travis |
|
Crater run started |
|
@aidanhs any update? :) |
|
We're still uploading to http://cargobomb-reports.s3.amazonaws.com/pr-50351/index.html, but there's only a single regression with |
|
Upload complete at http://cargobomb-reports.s3.amazonaws.com/pr-50351/index.html (sorry for the delay, uploading hit a bug in crater that I had to debug and fix) |
|
|
|
Reuploaded, the report generation was buggy too (so both logs were identical). Regarding the timeout - seems like normal variance, looking at the two logs it appears the one that passed squeaked by with just a few seconds under 300. |
pietroalbini
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 5489969 has been approved by |
bors
added
S-waiting-on-bors
Remove vestigial diverging !-coercion Such conversions are no longer permitted. Fixes #50350. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Such conversions are no longer permitted. Fixes #50350.
r? @nikomatsakis