Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: deny incoherent_fundamental_impls by default #50390

Merged
merged 4 commits into from
May 8, 2018
Merged

lint: deny incoherent_fundamental_impls by default #50390

merged 4 commits into from
May 8, 2018

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented May 2, 2018

Warn the ecosystem of the pending intent-to-disallow in #49799.

There are 4 ICEs on my machine, look unrelated (having happened before in #49146 (comment))

thread 'main' panicked at 'assertion failed: position <= slice.len()', libserialize/leb128.rs:97:1
    [run-pass] run-pass/allocator/xcrate-use2.rs
    [run-pass] run-pass/issue-12133-3.rs
    [run-pass] run-pass/issue-32518.rs
    [run-pass] run-pass/trait-default-method-xc-2.rs

r? @nikomatsakis

Warn the ecosystem of the pending intent-to-disallow in #49799.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:50:25] ............................................................................ii......................
[00:51:12] ........................................i....................................................i.ii...
[00:51:23] ............................test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:51:51] ........................................................................
[00:52:13] .iiiiiii............................................................................................
[00:52:52] ....................................................................................................
[00:53:09] ..........................................................................
[00:53:09] test result: ok. 2955 passed; 0 failed; 19 ignored; 0 measured; 0 filtered out
[00:53:09] 
---
[01:25:31] 
[01:25:31] failures:
[01:25:31] 
[01:25:31] ---- /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md - Warn_by_default_lints::incoherent_fundamental_impls (line 125) stdout ----
[01:25:31]  error: conflicting implementations of trait `main::Trait1<std::boxed::Box<_>>` for type `main::A`: (E0119)
[01:25:31]   --> /checkout/src/doc/rustc/src/lints/listing/warn-by-default.md:138:1
[01:25:31]    |
[01:25:31] 11 | impl<X, T> Trait1<X> for T where T: Trait2<X> {
[01:25:31]    | --------------------------------------------- first implementation here
[01:25:31] ...
[01:25:31] 15 | impl<X> Trait1<Box<X>> for A {
[01:25:31]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `main::A`
[01:25:31]    |
[01:25:31]    = note: #[deny(incoherent_fundamental_impls)] on by default
[01:25:31]    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
[01:25:31]    = note: for more information, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>
[01:25:31]    = note: downstream crates may implement trait `main::Trait2<std::boxed::Box<_>>` for type `main::A`
[01:25:31] thread '/checkout/src/doc/rustc/src/lints/listing/warn-by-default.md - Warn_by_default_lints::incoherent_fundamental_impls (line 125)' panicked at 'couldn't compile the test', librustdoc/test.rs:321:13
[01:25:31] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:25:31] 
[01:25:31] 
---
[01:25:31] 
[01:25:31] 
[01:25:31] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:25:31] Build completed unsuccessfully in 0:45:28
[01:25:31] Makefile:58: recipe for target 'check' failed
[01:25:31] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03aa0ab0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@hdhoang
Copy link
Contributor Author

hdhoang commented May 2, 2018

looks like I need to coordinate with the src/doc submodule. How should I go about that?

@nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2018
@hdhoang
Copy link
Contributor Author

hdhoang commented May 3, 2018

Oh, how did I come to think doc was a submodule. I have updated the listings.

#49799 happened before doc/rustc came in, so I'll edit the lists again when merging this PR in via master.

@shepmaster shepmaster added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2018
@shepmaster
Copy link
Member

Ping from triage, @nikomatsakis — looks like this is back in your court!

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 7, 2018

📌 Commit cabbe50 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2018
@nikomatsakis
Copy link
Contributor

Thanks @hdhoang !

@bors
Copy link
Contributor

bors commented May 8, 2018

⌛ Testing commit cabbe50 with merge 295d980...

bors added a commit that referenced this pull request May 8, 2018
lint: deny incoherent_fundamental_impls by default

Warn the ecosystem of the pending intent-to-disallow in #49799.

There are 4 ICEs on my machine, look unrelated (having happened before in #49146 (comment))

```rust
thread 'main' panicked at 'assertion failed: position <= slice.len()', libserialize/leb128.rs:97:1
```

```
    [run-pass] run-pass/allocator/xcrate-use2.rs
    [run-pass] run-pass/issue-12133-3.rs
    [run-pass] run-pass/issue-32518.rs
    [run-pass] run-pass/trait-default-method-xc-2.rs
```

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented May 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 295d980 to master...

@bors bors merged commit cabbe50 into rust-lang:master May 8, 2018
@hdhoang hdhoang deleted the 46205_deny_by_default branch May 9, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants