Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #50448

Closed
wants to merge 1 commit into from
Closed

Update clippy #50448

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 4, 2018

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2018
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 4, 2018

📌 Commit cfaa8fe has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented May 4, 2018

@bors p=1

kennytm added a commit to kennytm/rust that referenced this pull request May 4, 2018
@kennytm
Rollup merge of rust-lang#50448 - oli-obk:clippy, r=Manishearth
6a1858a 
Update clippy

r? @Manishearth
@kennytm kennytm mentioned this pull request May 4, 2018
Closed
@bors
Copy link
Collaborator

bors commented May 4, 2018

⌛ Testing commit cfaa8fe with merge 107907dbda264f14b79c60c709e82560ec7eac73...

@bors
Copy link
Collaborator

bors commented May 4, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2018
@kennytm
Copy link
Member

kennytm commented May 4, 2018 •
edited
Loading

The new clippy regressed RLS. See #50449 (comment).

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2018
@oli-obk oli-obk closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rust-highfive @Manishearth @bors @kennytm