Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc_macro: Explicitly make everything !Send/Sync #50453

Merged
merged 1 commit into from
May 6, 2018
Merged

proc_macro: Explicitly make everything !Send/Sync #50453

merged 1 commit into from
May 6, 2018

Conversation

alexcrichton
Copy link
Member

This commit adds explicit imp blocks to ensure that all publicly exported types
(except simple enums) are not Send nor Sync in the proc_macro crate.

cc #38356

@alexcrichton
proc_macro: Explicitly make everything !Send/Sync
3e0ed2f 
This commit adds explicit imp blocks to ensure that all publicly exported types
(except simple enums) are not `Send` nor `Sync` in the `proc_macro` crate.

cc rust-lang#38356
@alexcrichton
Copy link
Member Author

r? @petrochenkov

@alexcrichton alexcrichton mentioned this pull request May 4, 2018
Closed
31 tasks
@eddyb
Copy link
Member

eddyb commented May 4, 2018

@bors r+

@bors
Copy link
Contributor

bors commented May 4, 2018

📌 Commit 3e0ed2f has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 4, 2018
@bors
Copy link
Contributor

bors commented May 6, 2018

⌛ Testing commit 3e0ed2f with merge df07f3d2114836dec175ebf6b5987d9416ed2de8...

@bors
Copy link
Contributor

bors commented May 6, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 6, 2018
@alexcrichton
Copy link
Member Author

@bors: retry

I sure hope this didn't cause rustc to segfault..

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2018
@bors
Copy link
Contributor

bors commented May 6, 2018

⌛ Testing commit 3e0ed2f with merge ce0cb14...

bors added a commit that referenced this pull request May 6, 2018
@bors
Auto merge of #50453 - alexcrichton:proc-macro-not-send, r=eddyb
ce0cb14 
proc_macro: Explicitly make everything !Send/Sync

This commit adds explicit imp blocks to ensure that all publicly exported types
(except simple enums) are not `Send` nor `Sync` in the `proc_macro` crate.

cc #38356
@bors
Copy link
Contributor

bors commented May 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing ce0cb14 to master...

@bors bors merged commit 3e0ed2f into rust-lang:master May 6, 2018
@bors bors mentioned this pull request May 6, 2018
Merged
@alexcrichton alexcrichton deleted the proc-macro-not-send branch May 10, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexcrichton @eddyb @bors @petrochenkov