Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private::exclusive_unwrap_conflict test. Fixes #4689. #5078

Closed
wants to merge 1 commit into from
Closed

Fix private::exclusive_unwrap_conflict test. Fixes #4689. #5078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libcore/private.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ pub mod tests {
res.recv();
}

#[test] #[should_fail] #[ignore(reason = "random red")]
#[test] #[should_fail] #[ignore(cfg(windows))]
pub fn exclusive_unwrap_conflict() {
let x = exclusive(~~"hello");
let x2 = ~mut Some(x.clone());
Expand All @@ -505,7 +505,8 @@ pub mod tests {
}
assert unwrap_exclusive(x) == ~~"hello";
let res = option::swap_unwrap(&mut res);
res.recv();
// See #4689 for why this can't be just "res.recv()".
assert res.recv() == task::Success;
}

#[test] #[ignore(cfg(windows))]
Expand Down