Fix an ICE when attempting to transmute an uninhabited type #50803
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
never-transmute-never
branch
from
23cc8da to
e6c9a68
Compare
| f(x) | ||
| } | ||
|
|
||
| fn main() {} |
There was a problem hiding this comment.
This test doesn't seem to trigger the ICE on current nightly. Possibly because the unused functions get never codegen'd?
NB: I would have expected a compile-pass test instead of run-pass (and with suitable crate type to avoid the dummy main)
There was a problem hiding this comment.
Good point on both counts — I've updated the test; thanks.
varkor
force-pushed
the
never-transmute-never
branch
from
e6c9a68 to
d5de930
Compare
|
r? @eddyb |
src/librustc_trans/mir/block.rs
Outdated
| // we can do what we like. Here, we declare that transmuting | ||
| // into an uninhabited type is impossible, so anything following | ||
| // it must be unreachable. | ||
| bx.unreachable(); |
There was a problem hiding this comment.
Could you assert_eq!(bx.cx.layout_of(sig.output()).abi, Abi::Uninhabited) here?
|
@bors r+ |
|
📌 Commit d8cba6b has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #50615) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
varkor
force-pushed
the
never-transmute-never
branch
from
d8cba6b to
e172330
Compare
varkor
force-pushed
the
never-transmute-never
branch
2 times, most recently
from
a400529 to
f900333
Compare
|
@bors r+ |
|
📌 Commit f900333 has been approved by |
bors
added
S-waiting-on-bors
Fix an ICE when attempting to transmute an uninhabited type Fixes #50570.
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #50570.