-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #50847
Rollup of 10 pull requests #50847
Commits on May 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4f2cfb5 - Browse repository at this point
Copy the full SHA 4f2cfb5View commit details
Commits on May 10, 2018
-
- Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
Configuration menu - View commit details
-
Copy full SHA for 3f6b3bb - Browse repository at this point
Copy the full SHA 3f6b3bbView commit details
Commits on May 11, 2018
-
Tweak
nearest_common_ancestor()
.- Remove the "no nearest common ancestor found" case, because it's never hit in practise. (This means `closure_is_enclosed_by` can also be removed.) - Add a comment about why `SmallVec` is used for the "seen" structures. - Use `&Scope` instead of `Scope` to avoid some `map()` calls. - Use `any(p)` instead of `position(p).is_some()`.
Configuration menu - View commit details
-
Copy full SHA for a91f6f7 - Browse repository at this point
Copy the full SHA a91f6f7View commit details
Commits on May 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 8ab2d15 - Browse repository at this point
Copy the full SHA 8ab2d15View commit details
Commits on May 16, 2018
-
Fix grammar documentation wrt Unicode identifiers
The grammar defines identifiers in terms of XID_start and XID_continue, but this is referring to the unstable non_ascii_idents feature. The documentation implies that non_ascii_idents is forthcoming, but this is left over from pre-1.0 documentation; in reality, non_ascii_idents has been without even an RFC for several years now, and will not be stabilized anytime soon. Furthermore, according to the tracking issue at rust-lang#28979 , it's highly questionable whether or not this feature will use XID_start or XID_continue even when or if non_ascii_idents is stabilized. This commit fixes this by respecifying identifiers as the usual [a-zA-Z_][a-zA-Z0-9_]*
Configuration menu - View commit details
-
Copy full SHA for ce0b7cc - Browse repository at this point
Copy the full SHA ce0b7ccView commit details -
Null exclusions in grammar docs
The grammar documentation incorrectly says that comments, character literals, and string literals may not include null.
Configuration menu - View commit details
-
Copy full SHA for ab4735e - Browse repository at this point
Copy the full SHA ab4735eView commit details -
Avoid repeated HashMap lookups in
opt_normalize_projection_type
.There is a hot path through `opt_normalize_projection_type`: - `try_start` does a cache lookup (#1). - The result is a `NormalizedTy`. - There are no unresolved type vars, so we call `complete`. - `complete` does *another* cache lookup (#2), then calls `SnapshotMap::insert`. - `insert` does *another* cache lookup (rust-lang#3), inserting the same value that's already in the cache. This patch optimizes this hot path by introducing `complete_normalized`, for use when the value is known in advance to be a `NormalizedTy`. It always avoids lookup #2. Furthermore, if the `NormalizedTy`'s obligations are empty (the common case), we know that lookup rust-lang#3 would be a no-op, so we avoid it, while inserting a Noop into the `SnapshotMap`'s undo log.
Configuration menu - View commit details
-
Copy full SHA for f778bde - Browse repository at this point
Copy the full SHA f778bdeView commit details
Commits on May 17, 2018
-
Avoid allocations in
opt_normalize_projection_type
.This patch changes `opt_normalize_project_type` so it appends obligations to a given obligations vector, instead of returning a new obligations vector. This change avoids lots of allocations. In the most extreme case, for a clean "Check" build of serde it reduces the total number of allocations by 20%.
Configuration menu - View commit details
-
Copy full SHA for 47bc774 - Browse repository at this point
Copy the full SHA 47bc774View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37dee69 - Browse repository at this point
Copy the full SHA 37dee69View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceed8eb - Browse repository at this point
Copy the full SHA ceed8ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0356a61 - Browse repository at this point
Copy the full SHA 0356a61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74bfd94 - Browse repository at this point
Copy the full SHA 74bfd94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ac2fd1 - Browse repository at this point
Copy the full SHA 0ac2fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec0d946 - Browse repository at this point
Copy the full SHA ec0d946View commit details -
There was [some confusion](rust-lang#49767 (comment)) and I accidentally merged a PR that wasn't ready.
Configuration menu - View commit details
-
Copy full SHA for eac94d1 - Browse repository at this point
Copy the full SHA eac94d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfa26da - Browse repository at this point
Copy the full SHA cfa26daView commit details -
Rollup merge of rust-lang#50387 - phansch:remove_leftover_tab, r=alex…
…crichton Remove leftover tab in libtest outputs This removes some tabs that were present in the output of libtest. Related rust-lang#19299 Closes rust-lang#50362
Configuration menu - View commit details
-
Copy full SHA for 6e95b87 - Browse repository at this point
Copy the full SHA 6e95b87View commit details -
Rollup merge of rust-lang#50553 - clarcharr:option_xor, r=sfackler
Add Option::xor method Implements the method requested in rust-lang#50512.
Configuration menu - View commit details
-
Copy full SHA for 0c0bb18 - Browse repository at this point
Copy the full SHA 0c0bb18View commit details -
Rollup merge of rust-lang#50610 - estebank:fmt-str, r=Kimundi
Improve format string errors Point at format string position inside the formatting string: ``` error: invalid format string: unmatched `}` found --> $DIR/format-string-error.rs:21:22 | LL | let _ = format!("}"); | ^ unmatched `}` in format string ``` Explain that argument names can't start with an underscore: ``` error: invalid format string: invalid argument name `_foo` --> $DIR/format-string-error.rs:15:23 | LL | let _ = format!("{_foo}", _foo = 6usize); | ^^^^ invalid argument name in format string | = note: argument names cannot start with an underscore ``` Fix rust-lang#23476. The more accurate spans will only be seen when using `format!` directly, when using `println!` the diagnostics machinery makes the span be the entire statement.
Configuration menu - View commit details
-
Copy full SHA for b3734bd - Browse repository at this point
Copy the full SHA b3734bdView commit details -
Rollup merge of rust-lang#50649 - nnethercote:tweak-nearest_common_an…
…cestor, r=nikomatsakis Tweak `nearest_common_ancestor()`. - Remove the "no nearest common ancestor found" case, because it's never hit in practise. (This means `closure_is_enclosed_by` can also be removed.) - Add a comment about why `SmallVec` is used for the "seen" structures. - Use `&Scope` instead of `Scope` to avoid some `map()` calls. - Use `any(p)` instead of `position(p).is_some()`. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for e1848df - Browse repository at this point
Copy the full SHA e1848dfView commit details -
Rollup merge of rust-lang#50790 - bstrie:grammar, r=steveklabnik
Fix grammar documentation wrt Unicode identifiers The grammar defines identifiers in terms of XID_start and XID_continue, but this is referring to the unstable non_ascii_idents feature. The documentation implies that non_ascii_idents is forthcoming, but this is left over from pre-1.0 documentation; in reality, non_ascii_idents has been without even an RFC for several years now, and will not be stabilized anytime soon. Furthermore, according to the tracking issue at rust-lang#28979 , it's highly questionable whether or not this feature will use XID_start or XID_continue even when or if non_ascii_idents is stabilized. This commit fixes this by respecifying identifiers as the usual [a-zA-Z_][a-zA-Z0-9_]*
Configuration menu - View commit details
-
Copy full SHA for 77a4296 - Browse repository at this point
Copy the full SHA 77a4296View commit details -
Rollup merge of rust-lang#50791 - bstrie:null, r=QuietMisdreavus
Fix null exclusions in grammar docs The grammar documentation incorrectly says that comments, character literals, and string literals may not include null.
Configuration menu - View commit details
-
Copy full SHA for c95267e - Browse repository at this point
Copy the full SHA c95267eView commit details -
Rollup merge of rust-lang#50806 - oli-obk:gesundheit, r=ehuss
Add `bless` x.py subcommand for easy ui test replacement fixes rust-lang#49815 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for f83e4d7 - Browse repository at this point
Copy the full SHA f83e4d7View commit details -
Rollup merge of rust-lang#50818 - nnethercote:faster-normalize, r=nik…
…omatsakis Speed up `opt_normalize_projection_type` `opt_normalize_projection_type` is hot in the serde and futures benchmarks in rustc-perf. These two patches speed up the execution of most runs for them by 2--4%.
Configuration menu - View commit details
-
Copy full SHA for 54df1bf - Browse repository at this point
Copy the full SHA 54df1bfView commit details -
Rollup merge of rust-lang#50837 - steveklabnik:revert-49767, r=QuietM…
…isdreavus Revert rust-lang#49767 There was [some confusion](rust-lang#49767 (comment)) and I accidentally merged a PR that wasn't ready.
Configuration menu - View commit details
-
Copy full SHA for 53ea73a - Browse repository at this point
Copy the full SHA 53ea73aView commit details -
Rollup merge of rust-lang#50839 - glassresistor:master, r=steveklabnik
Make sure people know the book is free oline I've used the tutorial a number of times to relearn rust basics. When i saw this for a moment I was sad thinking it had been taken offline.
Configuration menu - View commit details
-
Copy full SHA for faa1f21 - Browse repository at this point
Copy the full SHA faa1f21View commit details