Skip to content

Issue #50636: Improve error diagnostic with missing commas after struct fields. #50914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5797,9 +5797,18 @@ impl<'a> Parser<'a> {
return Err(err);
}
}
_ => return Err(self.span_fatal_help(self.span,
&format!("expected `,`, or `}}`, found `{}`", self.this_token_to_string()),
"struct fields should be separated by commas")),
_ => {
let sp = self.sess.codemap().next_point(self.prev_span);
let mut err = self.struct_span_err(sp, &format!("expected `,`, or `}}`, found `{}`",
self.this_token_to_string()));
if self.token.is_ident() {
// This is likely another field; emit the diagnostic and keep going
err.span_suggestion(sp, "try adding a comma", ",".into());
err.emit();
} else {
return Err(err)
}
}
}
Ok(a_var)
}
Expand Down
23 changes: 23 additions & 0 deletions src/test/ui/struct-missing-comma.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags: -Z parse-only

// Issue #50636

struct S {
foo: u32 //~ expected `,`, or `}`, found `bar`
// ~^ HELP try adding a comma: ','
bar: u32
}

fn main() {
let s = S { foo: 5, bar: 6 };
}
8 changes: 8 additions & 0 deletions src/test/ui/struct-missing-comma.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: expected `,`, or `}`, found `bar`
--> $DIR/struct-missing-comma.rs:16:13
|
LL | foo: u32 //~ expected `,`, or `}`, found `bar`
| ^ help: try adding a comma: `,`

error: aborting due to previous error