-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prohibit turbofish in impl Trait
methods
#51051
Merged
bors
merged 1 commit into
rust-lang:master
from
nikomatsakis:turbofish-impl-trait-method
May 25, 2018
Merged
prohibit turbofish in impl Trait
methods
#51051
bors
merged 1 commit into
rust-lang:master
from
nikomatsakis:turbofish-impl-trait-method
May 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 24, 2018
nikomatsakis
added
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
May 24, 2018
@bors r+ p=100 |
📌 Commit 558cbfb has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 25, 2018
bors
added a commit
that referenced
this pull request
May 25, 2018
prohibit turbofish in `impl Trait` methods Fix #50950
☀️ Test successful - status-appveyor, status-travis |
This needs to be approved for beta by someone from @rust-lang/compiler. |
oli-obk
added
beta-accepted
Accepted for backporting to the compiler in the beta channel.
and removed
beta-nominated
Nominated for backporting to the compiler in the beta channel.
labels
May 31, 2018
Merged
bors
added a commit
that referenced
this pull request
Jun 1, 2018
[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50827: Update LLVM to `56c931901cfb85cd6f7ed44c7d7520a8de1edf97` * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in `impl Trait` methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost
pietroalbini
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
and removed
beta-nominated
Nominated for backporting to the compiler in the beta channel.
labels
Jun 3, 2018
bors
added a commit
that referenced
this pull request
Jun 3, 2018
[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in impl Trait methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50950