Check for confusable Unicode chars in float literal exponent #51075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FatalError.raise()` might seem unmotivated (in most places in the compiler, `err.emit()` suffices), but it's actually used to maintain behavior (viz., stop lexing, don't emit potentially spurious errors looking for the next token after the bad Unicodepoint in the exponent): the previous revision's `self.err_span_` ultimately calls `Handler::emit`, which aborts if the `Handler`'s continue_after_error flag is set, which seems to typically be true during lexing (see `phase_1_parse_input` and and how `CompileController::basic` has `continue_parse_after_error: false` in librustc_driver). Also, let's avoid apostrophes in error messages (the present author would argue that users expect a reassuringly detached, formal, above-it-all tone from a Serious tool like a compiler), and use an RLS-friendly structured suggestion. Resolves rust-lang#49746.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @zackmdavis |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
and_the_case_of_the_confusable_float_exponent
branch
from
c75fefa to
6ed8668
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
|
📌 Commit 6ed8668 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- Travis failed (r=me after fixing that) |
bors
added
S-waiting-on-author
estebank
force-pushed
the
and_the_case_of_the_confusable_float_exponent
branch
from
6ed8668 to
7dec8a4
Compare
|
@estebank thanks! |
|
@bors r=eddyb |
|
📌 Commit 7dec8a4 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing tests for #49989. Resolves #49746.