Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

also check let arms and nested patterns for mutable borrows #51274

Merged
merged 1 commit into from
Jun 2, 2018
Merged

also check let arms and nested patterns for mutable borrows #51274

merged 1 commit into from
Jun 2, 2018

Conversation

nikomatsakis
Copy link
Contributor

Fixes #46557

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2018
@nikomatsakis
Copy link
Contributor Author

oh, let me bless the test. =)

@nikomatsakis nikomatsakis mentioned this pull request Jun 1, 2018
Closed
@Mark-Simulacrum
Copy link
Member

Should we backport this to beta since it does fix unsoundness?

@nikomatsakis
Copy link
Contributor Author

Fixed tests.

@nikomatsakis
Copy link
Contributor Author

@Mark-Simulacrum we could .. it's not a recent regression or anything though.

@nikomatsakis
Copy link
Contributor Author

OTOH it's a small patch and I believe the code is pretty old, would be a low-risk backport

@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 1, 2018
@nikomatsakis nikomatsakis mentioned this pull request Jun 1, 2018
Merged
@pietroalbini pietroalbini mentioned this pull request Jun 1, 2018
Merged
@eddyb
Copy link
Member

eddyb commented Jun 2, 2018

I hate the old borrowck, at this point it's an incoherent mess of recursive fine-prints.

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Jun 2, 2018

📌 Commit a667049 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018
@bors
Copy link
Contributor

bors commented Jun 2, 2018

⌛ Testing commit a667049 with merge d830f46...

bors added a commit that referenced this pull request Jun 2, 2018
@bors
Auto merge of #51274 - nikomatsakis:issue-46557-promote-ref-mut, r=eddyb
d830f46 
also check `let` arms and nested patterns for mutable borrows

Fixes #46557

r? @eddyb
@bors
Copy link
Contributor

bors commented Jun 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d830f46 to master...

@bors bors merged commit a667049 into rust-lang:master Jun 2, 2018
@pietroalbini pietroalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 7, 2018
@nikomatsakis
Copy link
Contributor Author

We could backport this, but there's no burning reason to do so. Clearing the backport flag.

@nikomatsakis nikomatsakis removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikomatsakis @Mark-Simulacrum @eddyb @bors @oli-obk @pietroalbini @rust-highfive