Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor slice iterator cleanups #51326

Merged
merged 3 commits into from
Jun 4, 2018
Merged

Various minor slice iterator cleanups #51326

merged 3 commits into from
Jun 4, 2018

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Jun 3, 2018

See individual commits

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2018
@sdroege
Copy link
Contributor Author

sdroege commented Jun 3, 2018

Currently also looking into moving the Chunks and ChunksMut into a single macro implementation (the code is basically the same), and the same for ExactChunks and ExactChunksMut. But that will probably go to a separate PR tomorrow or so

dtolnay
dtolnay approved these changes Jun 3, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jun 3, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 3, 2018

📌 Commit 10cf7bb has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 4, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51326 - sdroege:slice-iter-cleanup, r=dtolnay
c3eff19 
Various minor slice iterator cleanups

See individual commits
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 4, 2018
Merged
bors added a commit that referenced this pull request Jun 4, 2018
@bors
Auto merge of #51334 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
6232478 
Rollup of 6 pull requests

Successful merges:

 - #51288 (Remove rustdoc-specific is_import field from HIR)
 - #51299 (const fn integer operations)
 - #51317 (Allow enabling incremental via config.toml)
 - #51323 (Generate br for all two target SwitchInts)
 - #51326 (Various minor slice iterator cleanups)
 - #51329 (Remove the unused `-Z trans-time-graph` flag.)

Failed merges:
@bors bors merged commit 10cf7bb into rust-lang:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdroege @rust-highfive @dtolnay @bors