Do not promote union field accesses #51328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
added
beta-nominated
rust-highfive
added
the
S-waiting-on-review
|
@bors try cc @rust-lang/infra |
|
⌛ Trying commit eb31ae2 with merge 837532cd7e0efb12179afcab1098798e97dd5fab... |
|
@bors r+ cc @rust-lang/compiler |
|
📌 Commit eb31ae2 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 4, 2018
Do not promote union field accesses r? @eddyb technically a breaking change, but the code errored on the previous stable and produces UB + a warning on the current stable. I don't think we need a crater run in that case.
|
☀️ Test successful - status-appveyor, status-travis |
nikomatsakis
added
the
beta-accepted
|
Looks like the crater run had 0 reported regressions: https://cargobomb-reports.s3.amazonaws.com/pr-51328/index.html. |
kennytm
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb
technically a breaking change, but the code errored on the previous stable and produces UB + a warning on the current stable. I don't think we need a crater run in that case.