expansion/hygiene: Some renaming, refactoring and comments #51726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @abonander or @oli-obk |
|
Thanks for including me but I never understood the hygiene system very well anyway. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@oli-obk |
Move `is_builtin` for `Mark` to a separate flag
…n detail and cannot be inspected outside of `hygiene.rs`
|
Updated. |
|
+ one more refactoring commit |
|
This PR is going to murder clippy xD @bors r+ |
|
📌 Commit 20ce910 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 24, 2018
expansion/hygiene: Some renaming, refactoring and comments Pure refactoring, no functional changes. Commits are isolated and self-descriptive.
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jun 24, 2018
eddyb
reviewed
Jun 24, 2018
| @@ -85,9 +85,6 @@ impl ProcMacro for Quoter { | |||
| _: ::syntax_pos::Span, | |||
| stream: tokenstream::TokenStream) | |||
| -> tokenstream::TokenStream { | |||
| let mut info = cx.current_expansion.mark.expn_info().unwrap(); | |||
| info.callee.allow_internal_unstable = true; | |||
| cx.current_expansion.mark.set_expn_info(info); | |||
There was a problem hiding this comment.
How does this work, exactly? Does it rely on hygiene instead?
There was a problem hiding this comment.
Nevermind, I see that SyntaxExtension::ProcMacro got an extra field.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jun 25, 2018
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Jun 25, 2018
This was referenced Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactoring, no functional changes.
Commits are isolated and self-descriptive.