Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of TyImplTraitExistential #51979

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 2, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:31:09]    Compiling aho-corasick v0.6.4
[00:31:15]    Compiling tempfile v3.0.2
[00:31:49]    Compiling minifier v0.0.14
[00:31:52]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:31:54] error[E0531]: cannot find tuple struct/variant `TyImplTraitExistential` in this scope
[00:31:54]     --> librustdoc/clean/mod.rs:2990:13
[00:31:54]      |
[00:31:54] 2990 |             TyImplTraitExistential(hir_id, _, _) => {
[00:31:54] 
2618024 .
1715284 ./obj
1715252 ./obj/build
---
143020 ./obj/build/bootstrap/debug/incremental
129600 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu
129596 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release
128512 ./obj/build/bootstrap/debug/incremental/bootstrap-146vjsckowoo9
128508 ./obj/build/bootstrap/debug/incremental/bootstrap-146vjsckowoo9/s-f2itlysssx-1uzquc4-3nz1e0umpw6qu
112648 ./obj/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps
97520 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
89808 ./src/llvm/test/CodeGen
88892 ./obj/build/x86_64-unknown-linux-gnu/stage1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@nikomatsakis
Copy link
Contributor

@bors r+

(I presume the expectation is that this will allow for more uniform treatment of "explicit" existential types vs -> impl Trait...? It seems like the code is just a hair messier after this change, in that TyImplTraitExistential made it very clean to identify the cases versus checking the def of a path.)

@bors
Copy link
Contributor

bors commented Jul 2, 2018

📌 Commit 75a6fde has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2018
@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 2, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 3, 2018
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 3, 2018
bors added a commit that referenced this pull request Jul 3, 2018
Rollup of 13 pull requests

Successful merges:

 - #51548 (Initialize LLVM's AMDGPU target machine, if available.)
 - #51809 (Add read_exact_at and write_all_at methods to FileExt on unix)
 - #51914 (add outlives annotations to `BTreeMap`)
 - #51958 (Show known meta items in unknown meta items error)
 - #51973 (Make Stdio handle UnwindSafe)
 - #51977 (bootstrap: tests should use rustc from config.toml)
 - #51978 (Do not suggest changes to str literal if it isn't one)
 - #51979 (Get rid of `TyImplTraitExistential`)
 - #51980 (Emit column info in debuginfo for non msvc like targets)
 - #51982 (incr.comp.: Take names of children into account when computing the ICH of a module's HIR.)
 - #51997 (add entry for cargo-metadata feature to RELEASES)
 - #52004 (toolstate: Fixed detection of changed submodule, and other fixes.)
 - #52006 ( Change --keep-stage to apply more often)

Failed merges:

r? @ghost
@bors bors merged commit 75a6fde into rust-lang:master Jul 3, 2018
@oli-obk oli-obk deleted the lowering_cleanups4 branch June 15, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants