Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change --keep-stage to apply more often #52006

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Change --keep-stage to apply more often #52006

merged 2 commits into from
Jul 3, 2018

Commits on Jul 2, 2018

  1. Make explicit that assemble is not run from CLI

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    f5570d0 View commit details
    Browse the repository at this point in the history

  2. Change --keep-stage to apply more 

    Previously, the --keep-stage argument would only function for compilers
that were depended on by future stages. For example, if trying to build
a stage 1 compiler you could --keep-stage 0 to avoid re-building the
stage 0 compiler. However, this is often not what users want in
practice.

The new implementation essentially skips builds all higher stages of the
compiler, so an argument of 1 to keep-stage will skip rebuilds of the
libraries, just linking them into the sysroot. This is unlikely to work
well in cases where metadata or similar changes have been made, but is
likely fine otherwise.

This change is somewhat untested, but since it shouldn't have any effect
except with --keep-stage, I don't see that as a large problem.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    9eda4aa View commit details
    Browse the repository at this point in the history