-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .iter() calling suggestion when Iterator isn't implemented #52178
Conversation
This is not the correct fix. Often, when users try this, calling |
@varkor this error lint only emits when |
The changes to the tests are a net improvement, but we would fail to recommend |
Ping from triage! @estebank any update on this PR? |
Ping form triage, @estebank / @rust-lang/compiler: This PR requires your review. |
If we merge this change we'll need to cut a new ticket to go back to the drawing board and enable the compiler to suggest using
Doing so would imply modifying the flags supported by |
@estebank ok, I'll leave this open. |
Ping from triage! What is the status of the changes proposed here / the changes required to merge this PR? Per our current triage guidelines, a blocked PR will generally be closed after two weeks if no immediate progress is expected. Since there is no issue tracking the blockage of this PR, I wanted to ask about the current status before closing. |
@estabank yes, I'll keep this in my todo until that happens. |
Closes #50773
r? @estebank