Skip to content

Patch clippy_lints to use the in-tree clippy as well. #52282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Jul 12, 2018

Should fix the most recent RLS build break.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@kennytm kennytm changed the title [WIP] Patch clippy_lints to use the in-tree clippy as well. Patch clippy_lints to use the in-tree clippy as well. Jul 12, 2018
@kennytm
Copy link
Member Author

kennytm commented Jul 12, 2018

r? @nrc or @oli-obk

RLS is test-pass in https://travis-ci.org/rust-lang/rust/jobs/402940329 (raw log):

[01:32:50] {"rust-by-example":"test-pass","rls":"test-pass","book":"test-pass","miri":"build-fail","nomicon":"test-fail","clippy-driver":"test-pass","rustfmt":"test-pass","reference":"test-pass"}

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jul 12, 2018

Travis failure is just miri

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 12, 2018

📌 Commit 6aab3d0 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2018
@bors
Copy link
Collaborator

bors commented Jul 12, 2018

⌛ Testing commit 6aab3d0 with merge 68e97a904b53082c689c6a911058ce971d0193c5...

@bors
Copy link
Collaborator

bors commented Jul 12, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 12, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:09:07] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:09:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:09:07] Build completed unsuccessfully in 1:06:37
[01:09:07] {"rustfmt":"test-pass","rls":"test-pass","reference":"test-pass","book":"test-pass","rust-by-example":"test-pass","nomicon":"test-fail","miri":"test-pass","clippy-driver":"test-fail"}
[01:09:07] Verifying status of book...
---
travis_time:end:19523df9:start=1531380505204666365,finish=1531380505210560956,duration=5894591
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:048c8304
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0178de98
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:09:07] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:09:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:09:07] Build completed unsuccessfully in 1:06:37
[01:09:07] {"rustfmt":"test-pass","rls":"test-pass","reference":"test-pass","book":"test-pass","rust-by-example":"test-pass","nomicon":"test-fail","miri":"test-pass","clippy-driver":"test-fail"}
[01:09:07] Verifying status of book...
---
travis_time:end:19523df9:start=1531380505204666365,finish=1531380505210560956,duration=5894591
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:048c8304
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0178de98
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Jul 12, 2018

@bors retry

network failure

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2018
@bors
Copy link
Collaborator

bors commented Jul 12, 2018

⌛ Testing commit 6aab3d0 with merge de857bb...

bors added a commit that referenced this pull request Jul 12, 2018
Patch clippy_lints to use the in-tree clippy as well.

Should fix the most recent RLS build break.
@bors
Copy link
Collaborator

bors commented Jul 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing de857bb to master...

@bors bors merged commit 6aab3d0 into rust-lang:master Jul 12, 2018
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #52282!

Tested on commit de857bb.
Direct link to PR: #52282

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 12, 2018
Tested on commit rust-lang/rust@de857bb.
Direct link to PR: <rust-lang/rust#52282>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
@kennytm kennytm deleted the fix-rls-break branch July 12, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants