Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.27.1 release notes to master #52310

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Backport 1.27.1 release notes to master #52310

merged 1 commit into from
Jul 13, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2018
pietroalbini
pietroalbini requested changes Jul 12, 2018
View reviewed changes
RELEASES.md Outdated
- rustdoc would execute plugins in the /tmp/rustdoc/plugins directory
when running, which enabled executing code as some other user on a
given machine. This release fixes that vulnerability; you can read
more about this on the [blog][rustdoc-sec].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the CVE now that we have a number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to; stable doesn't have the CVE and it feels odd to make those edits to "past" release notes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we did not have the number when we released 1.27.1, and having it in there would be helpful if someone is searching when the vulnerability was fixed.

Also, we already merged other PRs changing past releases' notes (such as #51997 and #51868), and if we do 1.27.2 we can even get this to stable faster.

@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 12, 2018
@Mark-Simulacrum Mark-Simulacrum force-pushed the release-notes-backport-from-stable branch from e0d3f87 to 4c340a2 Compare July 12, 2018 16:42
@Mark-Simulacrum
Copy link
Member Author

Okay, updated to include the CVE.

@pietroalbini
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 12, 2018

📌 Commit 4c340a2 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2018
@pietroalbini pietroalbini mentioned this pull request Jul 12, 2018
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 12, 2018
bors added a commit that referenced this pull request Jul 12, 2018
@bors
Auto merge of #52308 - pietroalbini:beta-backports, r=pietroalbini
b5f5c60 
[beta] Rollup backports

Merged and approved:

* #51722: Updated RELEASES for 1.28.0
* #52193: step_by: leave time of item skip unspecified
* #52194: Remove rustdoc's plugins feature
* #52196: rustdoc: Hide struct and enum variant constructor imports
* #52310: Backport 1.27.1 release notes to master

r? @ghost
kennytm added a commit to kennytm/rust that referenced this pull request Jul 12, 2018
@kennytm
Rollup merge of rust-lang#52310 - Mark-Simulacrum:release-notes-backp…
cd78a44 
…ort-from-stable, r=pietroalbini

Backport 1.27.1 release notes to master

r? @pietroalbini
@kennytm kennytm mentioned this pull request Jul 12, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 13, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52310 - Mark-Simulacrum:release-notes-backp…
fed8105 
…ort-from-stable, r=pietroalbini

Backport 1.27.1 release notes to master

r? @pietroalbini
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 13, 2018
Closed
bors added a commit that referenced this pull request Jul 13, 2018
@bors
Auto merge of #52344 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
f15d651 
Rollup of 16 pull requests

Successful merges:

 - #51962 (Provide llvm-strip in llvm-tools component)
 - #52003 (Implement `Option::replace` in the core library)
 - #52156 (Update std::ascii::ASCIIExt deprecation notes)
 - #52242 (NLL: Suggest `ref mut` and `&mut self`)
 - #52244 (Don't display default generic parameters in diagnostics that compare types)
 - #52290 (Deny bare trait objects in src/librustc_save_analysis)
 - #52293 (Deny bare trait objects in librustc_typeck)
 - #52299 (Deny bare trait objects in src/libserialize)
 - #52300 (Deny bare trait objects in librustc_target and libtest)
 - #52302 (Deny bare trait objects in the rest of rust)
 - #52310 (Backport 1.27.1 release notes to master)
 - #52314 (Fix ICE when using a pointer cast as array size)
 - #52315 (Resolve FIXME(#27942))
 - #52316 (task: remove wrong comments about non-existent LocalWake trait)
 - #52322 (Update llvm-rebuild-trigger in light of LLVM 7 upgrade)
 - #52332 (dead-code lint: say "constructed", "called" for structs, functions)

Failed merges:

r? @ghost
kennytm added a commit to kennytm/rust that referenced this pull request Jul 13, 2018
@kennytm
Rollup merge of rust-lang#52310 - Mark-Simulacrum:release-notes-backp…
443150f 
…ort-from-stable, r=pietroalbini

Backport 1.27.1 release notes to master

r? @pietroalbini
@kennytm kennytm mentioned this pull request Jul 13, 2018
Merged
bors added a commit that referenced this pull request Jul 13, 2018
@bors
Auto merge of #52352 - kennytm:rollup, r=kennytm
254f879 
Rollup of 17 pull requests

Successful merges:

 - #51962 (Provide llvm-strip in llvm-tools component)
 - #52003 (Implement `Option::replace` in the core library)
 - #52156 (Update std::ascii::ASCIIExt deprecation notes)
 - #52280 (llvm-tools-preview: fix build-manifest)
 - #52290 (Deny bare trait objects in src/librustc_save_analysis)
 - #52293 (Deny bare trait objects in librustc_typeck)
 - #52299 (Deny bare trait objects in src/libserialize)
 - #52300 (Deny bare trait objects in librustc_target and libtest)
 - #52302 (Deny bare trait objects in the rest of rust)
 - #52310 (Backport 1.27.1 release notes to master)
 - #52315 (Resolve FIXME(#27942))
 - #52316 (task: remove wrong comments about non-existent LocalWake trait)
 - #52322 (Update llvm-rebuild-trigger in light of LLVM 7 upgrade)
 - #52330 (Don't silently ignore invalid data in target spec)
 - #52333 (CI: Enable core dump on Linux, and print their stack trace on segfault. )
 - #52346 (Fix typo in improper_ctypes suggestion)
 - #52350 (Bump bootstrap compiler to 1.28.0-beta.10)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 13, 2018

☔ The latest upstream changes (presumably #52352) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2018
@bors bors merged commit 4c340a2 into rust-lang:master Jul 13, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the release-notes-backport-from-stable branch June 8, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees

@pietroalbini pietroalbini

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @pietroalbini @bors @rust-highfive