Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide llvm-strip in llvm-tools component #51962

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Provide llvm-strip in llvm-tools component #51962

merged 1 commit into from
Jul 13, 2018

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Jul 1, 2018

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric

@crlf0710
Provide llvm-strip in llvm-tools component
de2ecea 
Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2018
@Mark-Simulacrum
Copy link
Member

@bors rollup

@crlf0710
Copy link
Member Author

crlf0710 commented Jul 2, 2018

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 2, 2018

📌 Commit de2ecea has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 2, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51962 - crlf0710:patch-2, r=alexcrichton
7fc299e 
Provide llvm-strip in llvm-tools component

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 2, 2018
Closed
@japaric japaric mentioned this pull request Jul 3, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jul 3, 2018
@pietroalbini
Rollup merge of rust-lang#51962 - crlf0710:patch-2, r=alexcrichton
33b065d 
Provide llvm-strip in llvm-tools component

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@pietroalbini pietroalbini mentioned this pull request Jul 3, 2018
Closed
@mati865
Copy link
Contributor

mati865 commented Jul 3, 2018

This tool is available form LLVM 7.0 onwards so it's blocked on #51966.
There is another solution however, commit that added this tool is relatively simple and could be backported: llvm-mirror/llvm@409ea28

@pietroalbini
Copy link
Member

This seems to have failed in the rollup on freebsd.
@bors r-

[01:00:52] Dist LlvmTools stage2 (x86_64-unknown-freebsd)
[01:00:52] thread 'main' panicked at 'fs::File::open(&src) failed with No such file or directory (os error 2)', bootstrap/lib.rs:1202:25
[01:00:52] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-freebsd --target x86_64-unknown-freebsd

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2018
@crlf0710
Copy link
Member Author

crlf0710 commented Jul 4, 2018

Let's mark this as blocked now, i think.

@alexcrichton alexcrichton added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2018
@kennytm
Copy link
Member

kennytm commented Jul 12, 2018

#51966 has been merged. Could this be just r+'ed directly or needs further changes for #51962 (comment)?

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 12, 2018
@crlf0710
Copy link
Member Author

@kennytm I think this doesn't need further changes. (if the llvm-strip is built with the #51966 LLVM 7.0)

@kennytm
Copy link
Member

kennytm commented Jul 12, 2018

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 12, 2018

📌 Commit de2ecea has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jul 12, 2018
@kennytm
Rollup merge of rust-lang#51962 - crlf0710:patch-2, r=alexcrichton
10443c8 
Provide llvm-strip in llvm-tools component

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@kennytm kennytm mentioned this pull request Jul 12, 2018
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 13, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51962 - crlf0710:patch-2, r=alexcrichton
030d60c 
Provide llvm-strip in llvm-tools component

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 13, 2018
Closed
bors added a commit that referenced this pull request Jul 13, 2018
@bors
Auto merge of #52344 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
f15d651 
Rollup of 16 pull requests

Successful merges:

 - #51962 (Provide llvm-strip in llvm-tools component)
 - #52003 (Implement `Option::replace` in the core library)
 - #52156 (Update std::ascii::ASCIIExt deprecation notes)
 - #52242 (NLL: Suggest `ref mut` and `&mut self`)
 - #52244 (Don't display default generic parameters in diagnostics that compare types)
 - #52290 (Deny bare trait objects in src/librustc_save_analysis)
 - #52293 (Deny bare trait objects in librustc_typeck)
 - #52299 (Deny bare trait objects in src/libserialize)
 - #52300 (Deny bare trait objects in librustc_target and libtest)
 - #52302 (Deny bare trait objects in the rest of rust)
 - #52310 (Backport 1.27.1 release notes to master)
 - #52314 (Fix ICE when using a pointer cast as array size)
 - #52315 (Resolve FIXME(#27942))
 - #52316 (task: remove wrong comments about non-existent LocalWake trait)
 - #52322 (Update llvm-rebuild-trigger in light of LLVM 7 upgrade)
 - #52332 (dead-code lint: say "constructed", "called" for structs, functions)

Failed merges:

r? @ghost
kennytm added a commit to kennytm/rust that referenced this pull request Jul 13, 2018
@kennytm
Rollup merge of rust-lang#51962 - crlf0710:patch-2, r=alexcrichton
d8b8402 
Provide llvm-strip in llvm-tools component

Shipping this tool gives people reliable way to reduce the generated executable size.

I'm not sure if this strip tool is available from the llvm version current rust is built on. But let's take a look. @japaric
@kennytm kennytm mentioned this pull request Jul 13, 2018
Merged
bors added a commit that referenced this pull request Jul 13, 2018
@bors
Auto merge of #52352 - kennytm:rollup, r=kennytm
254f879 
Rollup of 17 pull requests

Successful merges:

 - #51962 (Provide llvm-strip in llvm-tools component)
 - #52003 (Implement `Option::replace` in the core library)
 - #52156 (Update std::ascii::ASCIIExt deprecation notes)
 - #52280 (llvm-tools-preview: fix build-manifest)
 - #52290 (Deny bare trait objects in src/librustc_save_analysis)
 - #52293 (Deny bare trait objects in librustc_typeck)
 - #52299 (Deny bare trait objects in src/libserialize)
 - #52300 (Deny bare trait objects in librustc_target and libtest)
 - #52302 (Deny bare trait objects in the rest of rust)
 - #52310 (Backport 1.27.1 release notes to master)
 - #52315 (Resolve FIXME(#27942))
 - #52316 (task: remove wrong comments about non-existent LocalWake trait)
 - #52322 (Update llvm-rebuild-trigger in light of LLVM 7 upgrade)
 - #52330 (Don't silently ignore invalid data in target spec)
 - #52333 (CI: Enable core dump on Linux, and print their stack trace on segfault. )
 - #52346 (Fix typo in improper_ctypes suggestion)
 - #52350 (Bump bootstrap compiler to 1.28.0-beta.10)

Failed merges:

r? @ghost
@bors bors merged commit de2ecea into rust-lang:master Jul 13, 2018
@crlf0710 crlf0710 deleted the patch-2 branch July 14, 2018 12:15
@japaric japaric mentioned this pull request Aug 26, 2018
Closed
@ehuss ehuss mentioned this pull request May 25, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@crlf0710 @rust-highfive @Mark-Simulacrum @alexcrichton @bors @mati865 @pietroalbini @kennytm @nikomatsakis