Reach the body of functions returning `impl Trait` but don't treat it as public #52348

oli-obk · 2018-07-13T14:31:45Z

rust-highfive · 2018-07-13T14:46:33Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:01] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:01] tidy error: /checkout/src/test/run-pass/impl-trait/xcrate-issue-50865.rs: missing trailing newline
[00:04:01] tidy error: /checkout/src/test/run-pass/impl-trait/auxiliary/xcrate.rs: missing trailing newline
[00:04:01] tidy error: /checkout/src/test/ui/impl-trait/issue-52128.rs: missing trailing newline
[00:04:02] some tidy checks failed
[00:04:02] 
[00:04:02] 
[00:04:02] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:02] 
[00:04:02] 
[00:04:02] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:02] Build completed unsuccessfully in 0:00:49
[00:04:02] Build completed unsuccessfully in 0:00:49
[00:04:02] Makefile:79: recipe for target 'tidy' failed
[00:04:02] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06479a06
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:031cb24c:start=1531492702666551123,finish=1531492702675265237,duration=8714114
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02958537
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03bc514f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-07-13T17:02:23Z

src/librustc/middle/reachable.rs

+ if let ty::TyAnon(..) = t.sty {
+ self.0 = true;
+ }
+ t.super_visit_with(self)


Please use the flags machinery in rustc::ty instead. There might already be a flag and method for it there.

eddyb · 2018-07-13T17:03:11Z

src/librustc/middle/reachable.rs

- if self.def_id_represents_local_inlined_item(def_id) {
- self.worklist.push(node_id);
- } else {
+ if let Some(node_id) = self.tcx.hir.as_local_node_id(def_id) {


This looks like botched formatting.

eddyb · 2018-07-13T17:04:39Z

src/librustc_privacy/lib.rs

 if item_level.is_some() {
 // Reach the (potentially private) type and the API being exposed
- self.reach(item.id).ty().predicates();
+ self.reach(item.id).predicates();


The comment wasn't updated. Is the intention here that the "type" part doesn't need to be exported, unlike the "predicates", and the reachability pass should handle this instead?

eddyb · 2018-07-13T17:05:32Z

src/test/ui/impl-trait/issue-52128.rs

+
+}
+
+fn main() {}


Missing newline at the end of a few files.

eddyb · 2018-07-13T17:05:43Z

r? @petrochenkov

oli-obk · 2018-07-13T18:44:52Z

Nevermind. The fix is just using the correct variable -.- All the other stuff is for a different issue that I'll open a separate PR for.

petrochenkov · 2018-07-14T17:31:44Z

@bors r+

bors · 2018-07-14T17:31:45Z

📌 Commit 61414fd has been approved by petrochenkov

bors · 2018-07-15T04:01:49Z

⌛ Testing commit 61414fd with merge cc903c6...

@pnkfelix

Reach the body of functions returning `impl Trait` but don't treat it as public fixes #52128 r? @pnkfelix cc @eddyb

bors · 2018-07-15T06:31:19Z

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing cc903c6 to master...

rust-highfive assigned pnkfelix Jul 13, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2018

oli-obk added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 13, 2018

eddyb reviewed Jul 13, 2018

View reviewed changes

src/test/ui/impl-trait/issue-52128.rs

}

fn main() {}

Copy link

Member

eddyb Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at the end of a few files.

rust-highfive assigned petrochenkov and unassigned pnkfelix Jul 13, 2018

oli-obk force-pushed the bugfix branch from 75b44fd to 6e24627 Compare July 13, 2018 18:43

Use the correct visibility

61414fd

oli-obk force-pushed the bugfix branch from 6e24627 to 61414fd Compare July 13, 2018 18:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2018

bors added a commit that referenced this pull request Jul 15, 2018

Auto merge of #52348 - oli-obk:bugfix, r=petrochenkov

cc903c6

Reach the body of functions returning `impl Trait` but don't treat it as public fixes #52128 r? @pnkfelix cc @eddyb

bors merged commit 61414fd into rust-lang:master Jul 15, 2018

oli-obk deleted the bugfix branch June 15, 2020 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reach the body of functions returning `impl Trait` but don't treat it as public #52348

Reach the body of functions returning `impl Trait` but don't treat it as public #52348

oli-obk commented Jul 13, 2018 •

edited

Loading

rust-highfive commented Jul 13, 2018

eddyb Jul 13, 2018

eddyb Jul 13, 2018

eddyb Jul 13, 2018

eddyb Jul 13, 2018

eddyb commented Jul 13, 2018

oli-obk commented Jul 13, 2018

petrochenkov commented Jul 14, 2018

bors commented Jul 14, 2018

bors commented Jul 15, 2018

bors commented Jul 15, 2018

Reach the body of functions returning impl Trait but don't treat it as public #52348

Reach the body of functions returning impl Trait but don't treat it as public #52348

Conversation

oli-obk commented Jul 13, 2018 • edited Loading

rust-highfive commented Jul 13, 2018

eddyb Jul 13, 2018

Choose a reason for hiding this comment

eddyb Jul 13, 2018

Choose a reason for hiding this comment

eddyb Jul 13, 2018

Choose a reason for hiding this comment

eddyb Jul 13, 2018

Choose a reason for hiding this comment

eddyb commented Jul 13, 2018

oli-obk commented Jul 13, 2018

petrochenkov commented Jul 14, 2018

bors commented Jul 14, 2018

bors commented Jul 15, 2018

bors commented Jul 15, 2018

Reach the body of functions returning `impl Trait` but don't treat it as public #52348

Reach the body of functions returning `impl Trait` but don't treat it as public #52348

oli-obk commented Jul 13, 2018 •

edited

Loading