Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Fix two custom attributes with custom derive #52539

Merged
merged 1 commit into from
Jul 21, 2018

Commits on Jul 19, 2018

  1. rustc: Fix two custom attributes with custom derive

    This commit fixes an issue where multiple custom attributes could not be fed
    into a custom derive in some situations with the `use_extern_macros` feature
    enabled. The problem was that the macro expander didn't consider that it was
    making progress when we were deducing that attributes should be lumped in with
    custom derive invocations.
    
    The fix applied here was to track in the expander if our attribute is changing
    (getting stashed away elsewhere and replaced with a new invocation). If it is
    swapped then it's considered progress, otherwise behavior should remain the
    same.
    
    Closes rust-lang#52525
    alexcrichton committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    f2f7ab9 View commit details
    Browse the repository at this point in the history