-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loop label resolution around constants #52568
Conversation
Even if that is just happening because of `abort_if_errors`
This comment has been minimized.
This comment has been minimized.
src/librustc_errors/lib.rs
Outdated
@@ -274,7 +274,7 @@ pub struct Handler { | |||
err_count: AtomicUsize, | |||
emitter: Lock<Box<dyn Emitter + sync::Send>>, | |||
continue_after_error: LockCell<bool>, | |||
delayed_span_bug: Lock<Option<Diagnostic>>, | |||
delayed_span_bug: Lock<Vec<Diagnostic>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be called delayed_span_bugs
.
@@ -503,11 +519,18 @@ impl Handler { | |||
} | |||
pub fn delay_span_bug<S: Into<MultiSpan>>(&self, sp: S, msg: &str) { | |||
if self.flags.treat_err_as_bug { | |||
// FIXME: don't abort here if report_delayed_bugs is off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How straightforward is this to address in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it's easy. I just didn't want to change the default behaviour in this PR. ppl might get confused and not know about the extra flag you need to get the old behaviour back
@bors r+ |
📌 Commit bab5eb4 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? `@oli-obk`
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ``@oli-obk``
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ```@oli-obk```
…s, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ````@oli-obk````
Rollup merge of rust-lang#119567 - nnethercote:rm-Zreport-delayed-bugs, r=oli-obk Remove `-Zreport-delayed-bugs`. It's not used within the repository in any way (e.g. in tests), and doesn't seem useful. It was added in rust-lang#52568. r? ````@oli-obk````
And make
delay_span_bug
a little more helpfulr? @varkor
fixes #52442
fixes #52443