-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix issue #52475: Make loop detector only consider reachable memory #52626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7fa42be
Remove unused alloc_id_recursion_tracker
brunocodutra 0300774
Promote EvalSnapshot to newtype
brunocodutra a083aa0
Implement Hash in terms of HashStable for EvalSnapshot
brunocodutra 015f470
Move EvalSnapshot into its own module
brunocodutra 2f5c3fd
Make vaious allocation related types generic on the allocation id
brunocodutra adb1965
Introduce Snapshot and SnapshotContext traits
brunocodutra bf6ba97
Impl SnapshotContext for Memory
brunocodutra 927c709
Impl Eq and PartialEq for EvalSnapshot in terms of the Snapshot trait
brunocodutra 806ecab
Add regression test for #52475
brunocodutra 0a84ff0
Add an info log when snapshotting the constant evaluation context
brunocodutra 4eb8d94
Add a convenience macro to reduce code duplication
brunocodutra add9ee2
Keep lines shorter than 100 characters
brunocodutra a26ceb3
Use EvalContext's TyCtx for the purpose of hashing the evaluation con…
brunocodutra 61a999a
Move InfiniteLoopDetector to snapshot.rs
brunocodutra 05cdf8d
Document snapshot.rs
brunocodutra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.