Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Z borrowck=migrate #52681

Merged
merged 10 commits into from
Jul 27, 2018
Merged

Add -Z borrowck=migrate #52681

merged 10 commits into from
Jul 27, 2018

Commits on Jul 26, 2018

  1. Add flag indicating whether AST borrowck query signalled any error.

    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    655894b View commit details
    Browse the repository at this point in the history

  2. Add -Z borrowck=migrate flag, use it to link NLL up to AST-borrowck.

    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    a23e8a7 View commit details
    Browse the repository at this point in the history

  3. Add migrate to list of values for -Z borrowck=...

    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    ff2f9e0 View commit details
    Browse the repository at this point in the history

  4. Allow elaborate_drops to progress under errors that come up during bo… 

    …rrowck=migrate.
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    3460115 View commit details
    Browse the repository at this point in the history

  5. Add scary warnings to errors-downgraded-to-warnings in borrowck=migrate. 

    Also convert an ICE that became reachable code under borrowck=migrate
into a normally reported error (which is then downgraded to a
warning). This actually has a nice side benefit of providing a
somewhat more useful error message, at least in the particular case of
the example from issue rust-lang#27282.
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    91dc3e5 View commit details
    Browse the repository at this point in the history

  6. Test for -Z borrowck=migrate. 

    Note that this test is carefully crafted to *try* to not segfault
during its run.  Howver, it really is representing unsound code that
should be rejected after we manage to remove the AST-borrowck entirely
from the compiler.
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    f808405 View commit details
    Browse the repository at this point in the history

  7. Bug fix: #![feature(nll)] takes precedence over -Z borrowck=migrate. 

    (Includes test illustrating desired behavior; compare its diagnostic
output to that of the file `borrowck-migreate-to-nll.rs`.)
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    1a59daf View commit details
    Browse the repository at this point in the history

  8. integrate the edition code. 

    As a driveby change, I made `#![feature(nll)]` *always* take
precedence over `-Z borrowck`.  The main effect this had is that it
means tests with `#![feature(nll)]` will ignore uses of `-Z
borrowck=compare`. This affected only one test as far as I can tell,
and I think that test used `-Z borrowck=compare` only as a historical
accident.
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    4b2e553 View commit details
    Browse the repository at this point in the history

  9. compiletest: Add support for ignoring certain tests under `--compare-… 

    …mode=...`
    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    94a2972 View commit details
    Browse the repository at this point in the history

  10. Incorporate edition flag testing into tests of -Z borrowck=migrate.

    @pnkfelix
    pnkfelix committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    9f05f29 View commit details
    Browse the repository at this point in the history