Cleanup for librustc::session #52758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
91e06fd to
bb24e1b
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
bb24e1b to
c7d1db0
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
c7d1db0 to
f5d6171
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
f5d6171 to
73f86c4
Compare
pnkfelix
reviewed
Jul 31, 2018
| tws => bug!("Unsupported target word size for isize: {}", tws), | ||
| } | ||
| }, | ||
| ast::IntTy::Isize => cx.tcx.sess.target.isize_ty.bit_width().unwrap() as u64, |
There was a problem hiding this comment.
this isn't a pure refactoring ... might a mischevious target attempt to choose a bitwidth other than {16,32,64} ?
Having said that, I don't particularly mind either way
There was a problem hiding this comment.
(and furthermore, this new code is arguably much cleaner and more directly expressing intent.)
There was a problem hiding this comment.
The isize_ty is created via an equivalent match anyway, so I don't think it matters much.
|
@bors r+ |
|
📌 Commit 73f86c4be4382b273aa309b8f79ad42764878326 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jul 31, 2018
|
@bors r- Merge conflicts |
bors
added
S-waiting-on-author
bors
added a commit
that referenced
this pull request
Aug 1, 2018
Rollup of 31 pull requests Successful merges: - #52332 (dead-code lint: say "constructed" for structs) - #52340 (Document From trait implementations for OsStr, OsString, CString, and CStr) - #52628 (Cleanup some rustdoc code) - #52732 (Remove unstable and deprecated APIs) - #52745 (Update clippy to latest master) - #52756 (rustc: Disallow machine applicability in foreign macros) - #52771 (Clarify thread::park semantics) - #52810 ([NLL] Don't make "fake" match variables mutable) - #52821 (pretty print for std::collections::vecdeque) - #52822 (Fix From<LocalWaker>) - #52824 (Fix -Wpessimizing-move warnings in rustllvm/PassWrapper) - #52831 (remove references to AUTHORS.txt file) - #52835 (Fix Alias intra doc ICE) - #52842 (update comment) - #52846 (Add timeout to use of `curl` in bootstrap.py.) - #52851 (Make the tool_lints actually usable) - #52853 (Improve bootstrap help on stages) - #52859 (Use Vec::extend in SmallVec::extend when applicable) - #52861 (Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.) - #52867 (releases.md: fix 2 typos) - #52870 (Implement Unpin for FutureObj and LocalFutureObj) - #52876 (run-pass/const-endianness: negate before to_le()) - #52878 (Fix wrong issue number in the test name) - #52883 (Include lifetime in mutability suggestion in NLL messages) - #52904 (NLL: sort diagnostics by span) - #52905 (Fix a typo in unsize.rs) - #52907 (NLL: On "cannot move out of type" error, print original before rewrite) - #52908 (Use SetLenOnDrop in Vec::truncate()) - #52914 (Only run the sparc-abi test on sparc) - #52918 (Backport 1.27.2 release notes) - #52929 (Update compatibility note for 1.28.0 to be correct) Failed merges: - #52758 (Cleanup for librustc::session) - #52799 (Use BitVector for global sets of AttrId) r? @ghost
|
@bors r=pnkfelix |
|
📌 Commit 73f86c4be4382b273aa309b8f79ad42764878326 has been approved by |
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
73f86c4 to
4df3722
Compare
bors
added
S-waiting-on-bors
This is a clippy-breaking change.
Mark-Simulacrum
force-pushed
the
session-cleanup
branch
from
4df3722 to
0ae2aa2
Compare
|
@bors r=pnkfelix |
|
📌 Commit 0ae2aa2 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 12, this pull request will be tested once the tree is reopened |
bors
added a commit
that referenced
this pull request
Aug 4, 2018
Cleanup for librustc::session Some rather straightforward cleanup. Each commit mostly stands alone.
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #52758! Tested on commit 94c3c34. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 4, 2018
Tested on commit rust-lang/rust@94c3c34. Direct link to PR: <rust-lang/rust#52758> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rather straightforward cleanup. Each commit mostly stands alone.