Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustfmt, RLS, Clippy #53057

Merged
merged 1 commit into from
Aug 5, 2018
Merged

Update rustfmt, RLS, Clippy #53057

merged 1 commit into from
Aug 5, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Aug 4, 2018

r? @kennytm

Fixes RLS build and updates RLS and Rustfmt to their 1.0 RCs

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2018
@kennytm
Copy link
Member

kennytm commented Aug 4, 2018

r=me when CI is green (unfortunately Travis is currently down 😥)

@bors p=9

@kennytm
Copy link
Member

kennytm commented Aug 4, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Aug 4, 2018

📌 Commit abf152720297ddcb7061cc7bb7b553c9fa76571d has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2018
@bors
Copy link
Contributor

bors commented Aug 4, 2018

⌛ Testing commit abf152720297ddcb7061cc7bb7b553c9fa76571d with merge b24c35874e9abdc72fca85212cf4a5eda1f44fd0...

@bors
Copy link
Contributor

bors commented Aug 4, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 4, 2018
@nrc
Copy link
Member Author

nrc commented Aug 4, 2018

Oh my, Clippy was busted again

@nrc
Copy link
Member Author

nrc commented Aug 4, 2018

Clippy fix: rust-lang/rust-clippy#3003

@nrc
Copy link
Member Author

nrc commented Aug 4, 2018

@bors: r=kennytm

@bors
Copy link
Contributor

bors commented Aug 4, 2018

📌 Commit 9a769c6 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2018
@Mark-Simulacrum Mark-Simulacrum changed the title Update rustfmt and RLS Update rustfmt, RLS, Clippy Aug 4, 2018
@bors
Copy link
Contributor

bors commented Aug 4, 2018

⌛ Testing commit 9a769c6 with merge dbcb33f...

bors added a commit that referenced this pull request Aug 4, 2018
Update rustfmt, RLS, Clippy

r? @kennytm

Fixes RLS build and updates RLS and Rustfmt to their 1.0 RCs
@bors
Copy link
Contributor

bors commented Aug 5, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing dbcb33f to master...

@bors bors merged commit 9a769c6 into rust-lang:master Aug 5, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #53057!

Tested on commit dbcb33f.
Direct link to PR: #53057

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 5, 2018
Tested on commit rust-lang/rust@dbcb33f.
Direct link to PR: <rust-lang/rust#53057>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants