Update RLS, Rustfmt, and Clippy #53141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust-highfive
added
the
S-waiting-on-review
kennytm
reviewed
Aug 7, 2018
src/Cargo.lock
Outdated
| version = "2.1.2" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| version = "2.1.3" | ||
| source = "git+https://github.com/racer-rust/racer?rev=2af3ab88420e968500fcfc75418be7e852debfa0#2af3ab88420e968500fcfc75418be7e852debfa0" |
There was a problem hiding this comment.
Could we depend on the released racer 2.1.3 (or publish a 2.1.4 if the released one is outdated)? Using a git dependency will fail tidy.
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-waiting-on-author
|
Fixed the Racer issue by making 2.1.4 |
This comment has been minimized.
This comment has been minimized.
|
You need to update Clippy as well (RLS depends on |
|
@bors r+ p=82 |
|
📌 Commit 53f6810d7299841e3fe59fde77825f30620b0eb6 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
@bors r=kennytm |
|
📌 Commit a1f2be9160194624fc2a68a4c91f9013ba3fc649 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a1f2be9160194624fc2a68a4c91f9013ba3fc649 with merge 9d6df50baa7007f254c67bd34023f7f00891058a... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r- retry |
bors
removed
the
S-waiting-on-bors
|
Now with updated Clippy too (I think I updated before @oli-obk 's clippy fix landed) |
|
@bors: r+ |
|
📌 Commit 785db92542cb59123ab83a64633d0f6dea175606 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 785db92542cb59123ab83a64633d0f6dea175606 with merge e23fcdba76ed904281cccfc2a1bc2b1fb543a974... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@nrc if you get a chance, mind throwing this diff in as well to prevent #53006 from happening again as well? (commenting out the |
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-waiting-on-author
author: alexcrichton
|
And another Clippy update and Alex's patch @bors: r+ |
|
📌 Commit ae5a1fd has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
|
📣 Toolstate changed by #53141! Tested on commit 52c785b. 🎉 clippy-driver on windows: build-fail → test-pass. |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 8, 2018
Tested on commit rust-lang/rust@52c785b. Direct link to PR: <rust-lang/rust#53141> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 🎉 rustfmt on windows: build-fail → test-pass. 🎉 rustfmt on linux: build-fail → test-pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bustage due to #52332
r? @kennytm