skip trivial Sized predicates
#53248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Aug 18, 2018
| /// | ||
| /// Returning true means the type is known to be sized. Returning | ||
| /// `false` means nothing -- could be sized, might not be. | ||
| pub fn is_trivially_sized(&self, tcx: TyCtxt<'_, '_, 'tcx>) -> bool { |
There was a problem hiding this comment.
Huh, didn't we use to have something like this?
There was a problem hiding this comment.
I thought so too but I didn't find it...
|
@bors r+ |
|
📌 Commit 1341e66 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1341e66 with merge 4b5307745b567835dbe3cbcaebba87a8a4b89d4c... |
bors
added a commit
that referenced
this pull request
Aug 19, 2018
skip trivial `Sized` predicates This came to about a 2% win for me in cargo. Small, but hey. r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
|
We got some nice improvements from this PR and/or #53258 and/or #53316, on both NLL and non-NLL benchmarks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came to about a 2% win for me in cargo. Small, but hey.
r? @eddyb