Skip to content

Various changes to rustc_on_unimplemented #53295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

estebank
Copy link
Contributor

  • Add from_method and from_desugaring to formatting options
  • Change wording of errors slightly

- Add `from_method` and `from_desugaring` to formatting options
- Change wording of errors slightly
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2018
@michaelwoerister
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2018

📌 Commit 5ae3801 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2018
@bors
Copy link
Collaborator

bors commented Aug 16, 2018

⌛ Testing commit 5ae3801 with merge 996e26c...

bors added a commit that referenced this pull request Aug 16, 2018
Various changes to `rustc_on_unimplemented`

- Add `from_method` and `from_desugaring` to formatting options
- Change wording of errors slightly
@bors
Copy link
Collaborator

bors commented Aug 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 996e26c to master...

@bors bors merged commit 5ae3801 into rust-lang:master Aug 16, 2018
@estebank estebank deleted the on-unimplemented branch November 9, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants