-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort reported 'similar impl candidates' alphabetically #53323
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
r? @estebank |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than fixing the test, r=me.
Thanks for fixing this!
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// issue-53302 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fbdc356
to
e977403
Compare
ಠ_ಠ |
@estebank Ready. |
@bors r+ rollup |
📌 Commit e97740346ca6f5e79b3e59fca7bf558f43119cbe has been approved by |
@bors r- Merge conflict |
e977403
to
1302d1f
Compare
Rebased. Doing a local test run just to make sure I merged right. |
Oh yeah, a bunch of tests moved into ui, didn't they. 20 (EDIT: 33?) "failures." |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Turns out this was subsumed as a part of #53196. Closing. |
Fixes #53302
Thanks to @estebank for the mentor-like info.